Changeset 21710 in webkit


Ignore:
Timestamp:
May 24, 2007 8:11:51 AM (17 years ago)
Author:
harrison
Message:

Reviewed by Tim Hatcher.

<rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()


_private->loader->frameLoader() was not being nil checked.

  • WebView/WebDataSource.mm: (-[WebDataSource request]): Add nil check for _private->loader->frameLoader()
Location:
trunk/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/ChangeLog

    r21688 r21710  
     12007-05-24  David Harrison  <harrison@apple.com>
     2
     3        Reviewed by Tim Hatcher.
     4
     5        <rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()
     6       
     7        _private->loader->frameLoader() was not being nil checked.
     8        * WebView/WebDataSource.mm:
     9        (-[WebDataSource request]):
     10        Add nil check for _private->loader->frameLoader()
     11
    1122007-05-23  Anders Carlsson  <andersca@apple.com>
    213
  • trunk/WebKit/WebView/WebDataSource.mm

    r21479 r21710  
    405405- (NSMutableURLRequest *)request
    406406{
    407     if (!_private->loader->frameLoader()->frameHasLoaded())
     407    FrameLoader* frameLoader = _private->loader->frameLoader();
     408    if (!frameLoader || !frameLoader->frameHasLoaded())
    408409        return nil;
    409410
Note: See TracChangeset for help on using the changeset viewer.