Changeset 218085 in webkit


Ignore:
Timestamp:
Jun 11, 2017 10:02:38 PM (7 years ago)
Author:
mmaxfield@apple.com
Message:

fast/text/variations/getComputedStyle.html does not need to be asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=173246
<rdar://problem/31393842>

Reviewed by Sam Weinig.

I dont know why I made it asynchronous in the first place.

  • fast/text/variations/getComputedStyle.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r218083 r218085  
     12017-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        fast/text/variations/getComputedStyle.html does not need to be asynchronous
     4        https://bugs.webkit.org/show_bug.cgi?id=173246
     5        <rdar://problem/31393842>
     6
     7        Reviewed by Sam Weinig.
     8
     9        I dont know why I made it asynchronous in the first place.
     10
     11        * fast/text/variations/getComputedStyle.html:
     12
    1132017-06-09  Ryosuke Niwa  <rniwa@webkit.org>
    214

  • trunk/LayoutTests/fast/text/variations/getComputedStyle.html

    r211060 r218085  
    2121<div id="test7" style="font-family: 'Boxis'; font-variation-settings: 'hght' 999999;">a</div>
    2222<script>
    23 window.jsTestIsAsync = true;
    24 
    25 var promises = [];
    26 
    27 document.fonts.forEach(function(f) {
    28         promises.push(f.loaded);
    29 });
    30 
    31 Promise.all(promises).then(function() {
    32         shouldBeEqualToString("window.getComputedStyle(document.getElementById('test0')).getPropertyValue('font-variation-settings')", "'hght' 400");
    33         shouldBeEqualToString("window.getComputedStyle(document.getElementById('test1')).getPropertyValue('font-variation-settings')", "'hght' 500");
    34         shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).getPropertyValue('font-variation-settings')", "'wdth' 500, 'hght' 400");
    35         shouldBe("window.getComputedStyle(document.getElementById('test3')).getPropertyValue('font-variation-settings')", "window.getComputedStyle(document.getElementById('test2')).getPropertyValue('font-variation-settings')");
    36         shouldBeEqualToString("window.getComputedStyle(document.getElementById('test4')).getPropertyValue('font-variation-settings')", "normal");
    37         shouldBeEqualToString("window.getComputedStyle(document.getElementById('test5')).getPropertyValue('font-variation-settings')", "normal");
    38         shouldBeEqualToString("window.getComputedStyle(document.getElementById('test6')).getPropertyValue('font-variation-settings')", "normal");
    39         shouldBeEqualToString("window.getComputedStyle(document.getElementById('test7')).getPropertyValue('font-variation-settings')", "'hght' 999999");
    40         finishJSTest();
    41 });
     23shouldBeEqualToString("window.getComputedStyle(document.getElementById('test0')).getPropertyValue('font-variation-settings')", "'hght' 400");
     24shouldBeEqualToString("window.getComputedStyle(document.getElementById('test1')).getPropertyValue('font-variation-settings')", "'hght' 500");
     25shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).getPropertyValue('font-variation-settings')", "'wdth' 500, 'hght' 400");
     26shouldBe("window.getComputedStyle(document.getElementById('test3')).getPropertyValue('font-variation-settings')", "window.getComputedStyle(document.getElementById('test2')).getPropertyValue('font-variation-settings')");
     27shouldBeEqualToString("window.getComputedStyle(document.getElementById('test4')).getPropertyValue('font-variation-settings')", "normal");
     28shouldBeEqualToString("window.getComputedStyle(document.getElementById('test5')).getPropertyValue('font-variation-settings')", "normal");
     29shouldBeEqualToString("window.getComputedStyle(document.getElementById('test6')).getPropertyValue('font-variation-settings')", "normal");
     30shouldBeEqualToString("window.getComputedStyle(document.getElementById('test7')).getPropertyValue('font-variation-settings')", "'hght' 999999");
    4231</script>
    4332<script src="../../../resources/js-test-post.js"></script>
Note: See TracChangeset for help on using the changeset viewer.