Changeset 218494 in webkit

Timestamp:

Jun 19, 2017 9:34:44 AM (7 years ago)

Author:

pvollan@apple.com

Message:

[Win] fast/dom/assign-to-window-status.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=173512

Reviewed by Alex Christensen.

We should not dump status callbacks when test is done.

• DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::setStatusText):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/win/UIDelegate.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-06-19  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] fast/dom/assign-to-window-status.html is flaky.
+        https://bugs.webkit.org/show_bug.cgi?id=173512
+
+        Reviewed by Alex Christensen.
+
+        We should not dump status callbacks when test is done.
+
+        * DumpRenderTree/win/UIDelegate.cpp:
+        (UIDelegate::setStatusText):
+
 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Tools/DumpRenderTree/win/UIDelegate.cpp

@@ -659 +659 @@
 
 HRESULT UIDelegate::setStatusText(_In_opt_ IWebView*, _In_ BSTR text)
-{ 
-    if (gTestRunner->dumpStatusCallbacks())
+{
+    if (!done && gTestRunner->dumpStatusCallbacks())
         fprintf(testResult, "UI DELEGATE STATUS CALLBACK: setStatusText:%S\n", text ? text : L"");
     return S_OK;