Changeset 219136 in webkit

Timestamp:

Jul 5, 2017, 10:43:59 AM (9 years ago)

Author:

adachan@apple.com

Message:

Fix crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:]
​https://bugs.webkit.org/show_bug.cgi?id=174143
<rdar://problem/28384582>

Reviewed by Wenson Hsieh.

In -[WKActionSheet willRotate], we can't guarantee that the action sheet belongs
in a window, and passing nil to +[UIViewController _viewControllerForFullScreenPresentationFromView:]
throws an exception. To fix this, bail early if the result from -hostViewForSheet is nil.

• UIProcess/ios/WKActionSheet.mm:

(-[WKActionSheet willRotate]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKActionSheet.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-07-05  Ada Chan  <adachan@apple.com>
+
+        Fix crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:]
+        https://bugs.webkit.org/show_bug.cgi?id=174143
+        <rdar://problem/28384582>
+
+        Reviewed by Wenson Hsieh.
+
+        In -[WKActionSheet willRotate], we can't guarantee that the action sheet belongs
+        in a window, and passing nil to +[UIViewController _viewControllerForFullScreenPresentationFromView:]
+        throws an exception. To fix this, bail early if the result from -hostViewForSheet is nil.
+
+        * UIProcess/ios/WKActionSheet.mm:
+        (-[WKActionSheet willRotate]):
+
 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebKit2/UIProcess/ios/WKActionSheet.mm

@@ -154 +154 @@
 
     UIView *view = [_sheetDelegate hostViewForSheet];
+    if (!view)
+        return;
+
     UIViewController *presentingViewController = [UIViewController _viewControllerForFullScreenPresentationFromView:view];