Changeset 219555 in webkit

Timestamp:

Jul 17, 2017, 12:03:03 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

Web Automation: link and partial link queries don't work if the link contains formatting tags
​https://bugs.webkit.org/show_bug.cgi?id=174498

Reviewed by Brian Burg.

So, for example, if we find links with text "Foo" and there's a link like <a href=""><bA>Foo</b></a> we fail
with no such element error. This causes test test_Link_With_Formatting_Tags to fail.

• UIProcess/Automation/atoms/FindNodes.js:

(switch): Use descendant-or-self::text() instead of just text() in the links xpath expressions.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Automation/atoms/FindNodes.js (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-07-17  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Web Automation: link and partial link queries don't work if the link contains formatting tags
+        https://bugs.webkit.org/show_bug.cgi?id=174498
+
+        Reviewed by Brian Burg.
+
+        So, for example, if we find links with text "Foo" and there's a link like <a href=""><bA>Foo</b></a> we fail
+        with no such element error. This causes test test_Link_With_Formatting_Tags to fail.
+
+        * UIProcess/Automation/atoms/FindNodes.js:
+        (switch): Use descendant-or-self::text() instead of just text() in the links xpath expressions.
+
 2017-07-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js

@@ -38 +38 @@
     case "link text":
         strategy = "xpath";
-        query = ".//a[@href][text() = \"" + escape(query) + "\"]";
+        query = ".//a[@href][descendant-or-self::text() = \"" + escape(query) + "\"]";
         break;
     case "partial link text":
         strategy = "xpath";
-        query = ".//a[@href][contains(text(), \"" + escape(query) + "\")]";
+        query = ".//a[@href][contains(descendant-or-self::text(), \"" + escape(query) + "\")]";
         break;
     }