Changeset 219977 in webkit

Timestamp:

Jul 27, 2017, 1:13:55 AM (9 years ago)

Author:

zandobersek@gmail.com

Message:

[EME] Allow CDMInstance type traits specialization
​https://bugs.webkit.org/show_bug.cgi?id=174886

Reviewed by Xabier Rodriguez-Calvar.

Allow using the trait-based type casting for the CDMInstance class and its
derivatives. ImplementationType enumeration values are to be used and
returned from the new implementationType() virtual method. This method is
leveraged in the type trait specialization that enables using is<>() and
downcast<>() helpers for CDMInstance objects.

This will allow differentiating between CDMInstance implementations once
the media playback pipeline has to retrieve any key information that's
necessary for playback of encrypted content.

MockCDMInstance class overrides the implementationType() method, returning
the ImplementationType::Mock value. Type trait specializations for this
class aren't added since they're not needed anywhere at this point.

• platform/encryptedmedia/CDMInstance.h:
• testing/MockCDMFactory.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/encryptedmedia/CDMInstance.h (modified) (3 diffs)
• testing/MockCDMFactory.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-27  Zan Dobersek  <zdobersek@igalia.com>
+
+        [EME] Allow CDMInstance type traits specialization
+        https://bugs.webkit.org/show_bug.cgi?id=174886
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Allow using the trait-based type casting for the CDMInstance class and its
+        derivatives. ImplementationType enumeration values are to be used and
+        returned from the new implementationType() virtual method. This method is
+        leveraged in the type trait specialization that enables using is<>() and
+        downcast<>() helpers for CDMInstance objects.
+
+        This will allow differentiating between CDMInstance implementations once
+        the media playback pipeline has to retrieve any key information that's
+        necessary for playback of encrypted content.
+
+        MockCDMInstance class overrides the implementationType() method, returning
+        the ImplementationType::Mock value. Type trait specializations for this
+        class aren't added since they're not needed anywhere at this point.
+
+        * platform/encryptedmedia/CDMInstance.h:
+        * testing/MockCDMFactory.h:
+
 2017-07-27  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/platform/encryptedmedia/CDMInstance.h

@@ -35 +35 @@
 #include <wtf/Optional.h>
 #include <wtf/RefCounted.h>
+#include <wtf/TypeCasts.h>
 #include <wtf/Vector.h>
 
@@ -46 +47 @@
 public:
     virtual ~CDMInstance() { }
+
+    enum class ImplementationType {
+        Mock,
+    };
+
+    virtual ImplementationType implementationType() const = 0;
 
     enum SuccessValue {
@@ -91 +98 @@
 } // namespace WebCore
 
+#define SPECIALIZE_TYPE_TRAITS_CDM_INSTANCE(ToValueTypeName, ImplementationTypeName) \
+SPECIALIZE_TYPE_TRAITS_BEGIN(ToValueTypeName) \
+static bool isType(const WebCore::CDMInstance& instance) { return instance.implementationType() == ImplementationTypeName; } \
+SPECIALIZE_TYPE_TRAITS_END()
+
 #endif

trunk/Source/WebCore/testing/MockCDMFactory.h

@@ -128 +128 @@
 
 private:
+    ImplementationType implementationType() const final { return ImplementationType::Mock; }
     SuccessValue initializeWithConfiguration(const MediaKeySystemConfiguration&) final;
     SuccessValue setDistinctiveIdentifiersAllowed(bool) final;