Changeset 219979 in webkit

Timestamp:

Jul 27, 2017, 3:18:18 AM (9 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer][EME] Fix phony debug output in player base for supported key system
​https://bugs.webkit.org/show_bug.cgi?id=174888

Reviewed by Žan Doberšek.

The debug output was returning always false because that method
was not checking anything before. Now it is and should reflect it.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer][EME] Fix phony debug output in player base for supported key system
+        https://bugs.webkit.org/show_bug.cgi?id=174888
+
+        Reviewed by Žan Doberšek.
+
+        The debug output was returning always false because that method
+        was not checking anything before. Now it is and should reflect it.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+        (WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
+
 2017-07-27  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

@@ -1034 +1034 @@
 bool MediaPlayerPrivateGStreamerBase::supportsKeySystem(const String& keySystem, const String& mimeType)
 {
-    GST_INFO("Checking for KeySystem support with %s and type %s: false.", keySystem.utf8().data(), mimeType.utf8().data());
+    bool result = false;
 
 #if ENABLE(ENCRYPTED_MEDIA)
     if (equalLettersIgnoringASCIICase(keySystem, "org.w3.clearkey"))
-        return true;
-#endif
-
-    return false;
+        result = true;
+#endif
+
+    GST_DEBUG("checking for KeySystem support with %s and type %s: %s", keySystem.utf8().data(), mimeType.utf8().data(), result ? "true" : "false");
+    return result;
 }