⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 220041 in webkit


Ignore:
Timestamp:
Jul 29, 2017, 3:00:33 AM (9 years ago)
Author:
commit-queue@webkit.org
Message:

AX: FKA: Buttons need a visible focus indicator
​https://bugs.webkit.org/show_bug.cgi?id=171040
<rdar://problem/30922548>

Patch by Aaron Chu <​aaron_chu@apple.com> on 2017-07-29
Reviewed by Antoine Quint.

Source/WebCore:

Added a background color for the focus state of the icon buttons in modern media controls.

Test: media/modern-media-controls/button/button-focus-state.html

  • Modules/modern-media-controls/controls/button.css:

(button:focus):
(button:focus > picture):

  • Modules/modern-media-controls/controls/slider.css:

(.slider > input):

LayoutTests:

  • media/modern-media-controls/button/button-focus-state-expected.txt: Added.
  • media/modern-media-controls/button/button-focus-state.html: Added.
  • platform/ios-simulator/TestExpectations:
  • platform/mac-elcapitan/TestExpectations:
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r220039 r220041  
     12017-07-29  Aaron Chu  <aaron_chu@apple.com>
     2
     3        AX: FKA: Buttons need a visible focus indicator
     4        https://bugs.webkit.org/show_bug.cgi?id=171040
     5        <rdar://problem/30922548>
     6
     7        Reviewed by Antoine Quint.
     8
     9        * media/modern-media-controls/button/button-focus-state-expected.txt: Added.
     10        * media/modern-media-controls/button/button-focus-state.html: Added.
     11        * platform/ios-simulator/TestExpectations:
     12        * platform/mac-elcapitan/TestExpectations:
     13
    1142017-07-28  Sam Weinig  <sam@webkit.org>
    215

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r219983 r220041  
    125125media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
    126126
     127# There is no focus state for on iOS
     128media/modern-media-controls/button/button-focus-state.html [ Skip ]
     129
    127130# These tests rely on fullscreen which do not use the WebKit media controls on iOS
    128131media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html [ Skip ]

  • trunk/LayoutTests/platform/mac-elcapitan/TestExpectations

    r219631 r220041  
    66fast/forms/number/number-appearance-spinbutton-layer.html [ Skip ]
    77media/modern-media-controls/pip-support [ Skip ]
     8media/modern-media-controls/button/button-focus-state.html [ Skip ]

  • trunk/Source/WebCore/ChangeLog

    r220039 r220041  
     12017-07-29  Aaron Chu  <aaron_chu@apple.com>
     2
     3        AX: FKA: Buttons need a visible focus indicator
     4        https://bugs.webkit.org/show_bug.cgi?id=171040
     5        <rdar://problem/30922548>
     6
     7        Reviewed by Antoine Quint.
     8
     9        Added a background color for the focus state of the icon buttons in modern media controls.
     10
     11        Test: media/modern-media-controls/button/button-focus-state.html
     12
     13        * Modules/modern-media-controls/controls/button.css:
     14        (button:focus):
     15        (button:focus > picture):
     16        * Modules/modern-media-controls/controls/slider.css:
     17        (.slider > input):
     18
    1192017-07-28  Sam Weinig  <sam@webkit.org>
    220

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/button.css

    r219549 r220041  
    4949    /* Work around webkit.org/b/174565 by making the shrinking button's icon non-interactive */
    5050    pointer-events: none;
     51}
     52
     53button:focus {
     54    outline: none;
     55}
     56
     57button:focus > picture {
     58    background-color: -webkit-focus-ring-color !important;
     59    mix-blend-mode: normal !important;
    5160}
    5261

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.css

    r219662 r220041  
    8282    background-color: transparent;
    8383    -webkit-appearance: none !important;
     84    /* Disabling this for now because the outline is visualy inconsistent with the button
     85       focus state. Tracking at https://bugs.webkit.org/show_bug.cgi?id=174906 */
     86    outline: none;
    8487}
     88
    8589
    8690.ios .slider > input {
Note: See TracChangeset for help on using the changeset viewer.