Changeset 220058 in webkit

Timestamp:

Jul 31, 2017, 2:14:58 AM (9 years ago)

Author:

calvaris@igalia.com

Message:

Created a bool pretty printer at WTF for debugging purposes
​https://bugs.webkit.org/show_bug.cgi?id=174893

Reviewed by Darin Adler.

Source/WebCore:

Use WTF::boolPrettyPrinter in debugging messages.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::seek):

Source/WTF:

• wtf/PrintStream.cpp:

(WTF::printInternal): The overload taking bool uses boolForPrinting

• wtf/PrintStream.h:

(WTF::boolForPrinting): Converts a bool in "true" or "false".

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PrintStream.cpp (modified) (1 diff)
• WTF/wtf/PrintStream.h (modified) (2 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2017-07-31  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        Created a bool pretty printer at WTF for debugging purposes
+        https://bugs.webkit.org/show_bug.cgi?id=174893
+
+        Reviewed by Darin Adler.
+
+        * wtf/PrintStream.cpp:
+        (WTF::printInternal): The overload taking bool uses boolForPrinting
+        * wtf/PrintStream.h:
+        (WTF::boolForPrinting): Converts a bool in "true" or "false".
+
 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/WTF/wtf/PrintStream.cpp

@@ -109 +109 @@
 void printInternal(PrintStream& out, bool value)
 {
-    if (value)
-        out.print("true");
-    else
-        out.print("false");
+    out.print(boolForPrinting(value));
 }
 

trunk/Source/WTF/wtf/PrintStream.h

@@ -44 +44 @@
 class StringView;
 class UniquedStringImpl;
+
+inline const char* boolForPrinting(bool value)
+{
+    return value ? "true" : "false";
+}
 
 class PrintStream {
@@ -338 +343 @@
 } // namespace WTF
 
+using WTF::boolForPrinting;
 using WTF::CharacterDump;
 using WTF::PointerDump;

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-31  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        Created a bool pretty printer at WTF for debugging purposes
+        https://bugs.webkit.org/show_bug.cgi?id=174893
+
+        Reviewed by Darin Adler.
+
+        Use WTF::boolPrettyPrinter in debugging messages.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+        (WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
+        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+        (WebCore::MediaPlayerPrivateGStreamerMSE::seek):
+
 2017-07-30  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

@@ -1041 +1041 @@
 #endif
 
-    GST_DEBUG("checking for KeySystem support with %s and type %s: %s", keySystem.utf8().data(), mimeType.utf8().data(), result ? "true" : "false");
+    GST_DEBUG("checking for KeySystem support with %s and type %s: %s", keySystem.utf8().data(), mimeType.utf8().data(), boolForPrinting(result));
     return result;
 }

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

@@ -198 +198 @@
 
     m_isEndReached = false;
-    GST_DEBUG("m_seeking=%s, m_seekTime=%f", m_seeking ? "true" : "false", m_seekTime);
+    GST_DEBUG("m_seeking=%s, m_seekTime=%f", boolForPrinting(m_seeking), m_seekTime);
 }