Changeset 220429 in webkit

Timestamp:

Aug 8, 2017 4:53:04 PM (7 years ago)

Author:

beidson@apple.com

Message:

Don't enable default icon loading in WK1 for apps linked against old SDKs.
<rdar://problem/33724060> and ​https://bugs.webkit.org/show_bug.cgi?id=175342

Reviewed by Andy Estes.

• Misc/WebKitVersionChecks.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless

the app is linked against new WebKit with the new behavior.

Location:

trunk/Source/WebKitLegacy/mac

Files:

• ChangeLog (modified) (1 diff)
• Misc/WebKitVersionChecks.h (modified) (1 diff)
• WebCoreSupport/WebFrameLoaderClient.mm (modified) (3 diffs)

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2017-08-08  Brady Eidson  <beidson@apple.com>
+
+        Don't enable default icon loading in WK1 for apps linked against old SDKs.
+        <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
+
+        Reviewed by Andy Estes.
+
+        * Misc/WebKitVersionChecks.h:
+        * WebCoreSupport/WebFrameLoaderClient.mm:
+        (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
+          the app is linked against new WebKit with the new behavior.
+
 2017-08-07  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h

@@ -62 +62 @@
 #define WEBKIT_FIRST_VERSION_WITHOUT_LEGACY_BACKGROUNDSIZE_SHORTHAND_BEHAVIOR 0x02190100 // 537.1.0
 #define WEBKIT_FIRST_VERSION_WITH_INSECURE_CONTENT_BLOCKING 0x02590116 // 601.1.22
+#define WEBKIT_FIRST_VERSION_WITH_DEFAULT_ICON_LOADING 0x025C0126 // 604.1.38
+
 #else
 // <rdar://problem/6627758> Need to implement WebKitLinkedOnOrAfter

trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm

@@ -55 +55 @@
 #import "WebKitLogging.h"
 #import "WebKitNSStringExtras.h"
+#import "WebKitVersionChecks.h"
 #import "WebNSURLExtras.h"
 #import "WebNavigationData.h"
@@ -143 +144 @@
 #import <WebCore/WAKWindow.h>
 #import <WebCore/WebCoreThreadMessage.h>
-#import "WebKitVersionChecks.h"
 #import "WebMailDelegate.h"
 #import "WebUIKitDelegate.h"
@@ -2281 +2281 @@
     ASSERT(documentLoader);
 
+#if PLATFORM(MAC)
+    if (!WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITH_DEFAULT_ICON_LOADING)) {
+        for (auto& icon : icons)
+            documentLoader->didGetLoadDecisionForIcon(false, icon.second, 0);
+
+        return;
+    }
+#endif
+
     bool disallowedDueToImageLoadSettings = false;
     if (!frame->settings().loadsImagesAutomatically() && !frame->settings().loadsSiteIconsIgnoringImageLoadingSetting())