Changeset 220486 in webkit

Timestamp:

Aug 9, 2017 3:36:04 PM (7 years ago)

Author:

n_wang@apple.com

Message:

LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

• accessibility/presentation-role-iframe.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• accessibility/presentation-role-iframe.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-08-09  Nan Wang  <n_wang@apple.com>
+
+        LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=175194
+
+        Reviewed by Chris Fleizach.
+
+        In the test we have no way to control which iframe will be loaded first.
+        Output the logs at the end of the test so that they are in order.
+
+        * accessibility/presentation-role-iframe.html:
+
 2017-08-09  Commit Queue  <commit-queue@webkit.org>
 

trunk/LayoutTests/accessibility/presentation-role-iframe.html

@@ -31 +31 @@
 var test3Ran = false;
 
+var test1Log; 
+var test2Log; 
+var test3Log;
+
 // Run the test for a iframe that has presentation role and one that does not.
 // The children should be different.
@@ -37 +41 @@
   if (window.accessibilityController) {
     var content = accessibilityController.accessibleElementById("content" + testNumber);
-    debug(testNumber + ". Content child: " + content.childAtIndex(0).role);
-    debug(testNumber + ". Content grand child: " + content.childAtIndex(0).childAtIndex(0).role);
     if (testNumber == 1) {
          test1Ran = true;
+         test1Log = testLog(content, testNumber);
     } else if (testNumber == 2) {
          test2Ran = true;
+         test2Log = testLog(content, testNumber);
     } else if (testNumber == 3) {
          test3Ran = true;
+         test3Log = testLog(content, testNumber);
     }
 
     if (test3Ran && test2Ran && test1Ran) {
+        debug(test1Log);
+        debug(test2Log);
+        debug(test3Log);
         finishJSTest();
     }
   }
+}
+
+function testLog(content, testNumber) {
+    var result = testNumber + ". Content child: " + content.childAtIndex(0).role;
+    result += "\n" + testNumber + ". Content grand child: " + content.childAtIndex(0).childAtIndex(0).role;
+    return result;
 }
 </script>