Changeset 220531 in webkit


Ignore:
Timestamp:
Aug 10, 2017 9:59:28 AM (7 years ago)
Author:
mmaxfield@apple.com
Message:

Addressing post-review comments after r219173.
​https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

  • css/CSSFontStyleValue.h:
  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r220528 r220531  
     12017-08-10  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Addressing post-review comments after r219173.
     4        https://bugs.webkit.org/show_bug.cgi?id=174149
     5
     6        Unreviewed.
     7
     8        * css/CSSFontStyleValue.h:
     9        * editing/EditingStyle.cpp:
     10        (WebCore::identifierForStyleProperty):
     11
    1122017-08-10  Antti Koivisto  <antti@apple.com>
    213

  • trunk/Source/WebCore/css/CSSFontStyleValue.h

    r219173 r220531  
    4747    bool equals(const CSSFontStyleValue&) const;
    4848
    49     bool isItalic() const
     49    bool isItalicOrOblique() const
    5050    {
    5151        if (!obliqueValue) {

  • trunk/Source/WebCore/editing/EditingStyle.cpp

    r220443 r220531  
    143143{
    144144    RefPtr<CSSValue> value = extractPropertyValue(style, propertyID);
    145     if (propertyID == CSSPropertyFontStyle && is<CSSFontStyleValue>(value.get()) && downcast<CSSFontStyleValue>(value.get())->isItalic())
     145    if (propertyID == CSSPropertyFontStyle && is<CSSFontStyleValue>(value.get()) && downcast<CSSFontStyleValue>(value.get())->isItalicOrOblique())
    146146        return CSSValueItalic;
    147147    if (!is<CSSPrimitiveValue>(value.get()))
Note: See TracChangeset for help on using the changeset viewer.