Changeset 220566 in webkit

Timestamp:

Aug 10, 2017 5:36:23 PM (7 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Use @toNumber in builtins
​https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

• Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):

• Modules/streams/StreamInternals.js:

(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/streams/ReadableByteStreamInternals.js (modified) (3 diffs)
• Modules/streams/StreamInternals.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] Use @toNumber in builtins
+        https://bugs.webkit.org/show_bug.cgi?id=172692
+
+        Reviewed by Sam Weinig.
+
+        Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
+        a given argument to a number.
+
+        * Modules/streams/ReadableByteStreamInternals.js:
+        (privateInitializeReadableByteStreamController):
+        (readableByteStreamControllerRespond):
+        * Modules/streams/StreamInternals.js:
+        (validateAndNormalizeQueuingStrategy):
+        (enqueueValueWithSize):
+
 2017-08-10  Nan Wang  <n_wang@apple.com>
 

trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js

@@ -65 +65 @@
     this.@closeRequested = false;
 
-    let hwm = @Number(highWaterMark);
+    let hwm = @toNumber(highWaterMark);
     if (@isNaN(hwm) || hwm < 0)
         @throwRangeError("highWaterMark value is negative or not a number");
@@ -72 +72 @@
     let autoAllocateChunkSize = underlyingByteSource.autoAllocateChunkSize;
     if (autoAllocateChunkSize !== @undefined) {
-        autoAllocateChunkSize = @Number(autoAllocateChunkSize);
+        autoAllocateChunkSize = @toNumber(autoAllocateChunkSize);
         if (autoAllocateChunkSize <= 0 || autoAllocateChunkSize === @Number.POSITIVE_INFINITY || autoAllocateChunkSize === @Number.NEGATIVE_INFINITY)
             @throwRangeError("autoAllocateChunkSize value is negative or equal to positive or negative infinity");
@@ -394 +394 @@
     "use strict";
 
-    bytesWritten = @Number(bytesWritten);
+    bytesWritten = @toNumber(bytesWritten);
 
     if (@isNaN(bytesWritten) || bytesWritten === @Number.POSITIVE_INFINITY || bytesWritten < 0 )

trunk/Source/WebCore/Modules/streams/StreamInternals.js

@@ -85 +85 @@
 
     normalizedStrategy.size = size;
-    normalizedStrategy.highWaterMark = @Number(highWaterMark);
+    normalizedStrategy.highWaterMark = @toNumber(highWaterMark);
 
     if (@isNaN(normalizedStrategy.highWaterMark) || normalizedStrategy.highWaterMark < 0)
@@ -113 +113 @@
     "use strict";
 
-    size = @Number(size);
+    size = @toNumber(size);
     if (!@isFinite(size) || size < 0)
         @throwRangeError("size has an incorrect value");