Changeset 220570 in webkit


Ignore:
Timestamp:
Aug 10, 2017 6:41:56 PM (7 years ago)
Author:
n_wang@apple.com
Message:

Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

  • accessibility/press-target-uses-text-descendant-node.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r220555 r220570  
     12017-08-10  Nan Wang  <n_wang@apple.com>
     2
     3        Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
     4        https://bugs.webkit.org/show_bug.cgi?id=175272
     5        <rdar://problem/33756962>
     6
     7        Since accessibilityPress is async, we shouldn't rely on the timeout.
     8
     9        Reviewed by Chris Fleizach.
     10
     11        * accessibility/press-target-uses-text-descendant-node.html:
     12
    1132017-08-10  Ryan Haddad  <ryanhaddad@apple.com>
    214
  • trunk/LayoutTests/accessibility/press-target-uses-text-descendant-node.html

    r219906 r220570  
    3939    description("Make sure that when performing a press, we target the deepest descendant, but also one that is an Element at the least.");
    4040
     41    document.getElementById("link").addEventListener("click", pressedLink);
     42    document.getElementById("button").addEventListener("click", pressedButton);
    4143    function startTest() {
    4244       accessibilityController.accessibleElementById("link").press();
    43        setTimeout(function() {
    44            debug("\nNow pressing on button\n");
    45            accessibilityController.accessibleElementById("button").press();
    46            setTimeout(function() {
    47                finishJSTest();
    48            }, 10);
    49        }, 10);
    5045    }
    5146
    5247    if (window.accessibilityController) {
    5348       window.jsTestIsAsync = true;
     49    }
     50   
     51    function pressedLink() {
     52        debug("\nNow pressing on button\n");
     53        accessibilityController.accessibleElementById("button").press();
     54    }
     55   
     56    function pressedButton() {
     57        finishJSTest();
    5458    }
    5559
Note: See TracChangeset for help on using the changeset viewer.