Changeset 223137 in webkit


Ignore:
Timestamp:
Oct 10, 2017 12:24:03 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Views should explicitly remove event listeners from managers/Frame
​https://bugs.webkit.org/show_bug.cgi?id=175951

Patch by Ross Kirsling <Ross Kirsling> on 2017-10-10
Reviewed by Brian Burg.

  • UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:

(WI.ApplicationCacheDetailsSidebarPanel.prototype.closed):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype.closed):

  • UserInterface/Views/DebuggerDashboardView.js:

(WI.DebuggerDashboardView.prototype.closed):

  • UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.closed):

  • UserInterface/Views/NetworkGridContentView.js:

(WI.NetworkGridContentView.prototype.closed):

  • UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WI.ProbeDetailsSidebarPanel.prototype.closed):

  • UserInterface/Views/QuickConsole.js:

(WI.QuickConsole.prototype.closed):

  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel.prototype.closed):

  • UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype.closed):

Location:
trunk/Source/WebInspectorUI
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r223078 r223137  
     12017-10-10  Ross Kirsling  <ross.kirsling@sony.com>
     2
     3        Web Inspector: Views should explicitly remove event listeners from managers/Frame
     4        https://bugs.webkit.org/show_bug.cgi?id=175951
     5
     6        Reviewed by Brian Burg.
     7
     8        * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
     9        (WI.ApplicationCacheDetailsSidebarPanel.prototype.closed):
     10        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
     11        (WI.DOMNodeDetailsSidebarPanel.prototype.closed):
     12        * UserInterface/Views/DebuggerDashboardView.js:
     13        (WI.DebuggerDashboardView.prototype.closed):
     14        * UserInterface/Views/LogContentView.js:
     15        (WI.LogContentView.prototype.closed):
     16        * UserInterface/Views/NetworkGridContentView.js:
     17        (WI.NetworkGridContentView.prototype.closed):
     18        * UserInterface/Views/ProbeDetailsSidebarPanel.js:
     19        (WI.ProbeDetailsSidebarPanel.prototype.closed):
     20        * UserInterface/Views/QuickConsole.js:
     21        (WI.QuickConsole.prototype.closed):
     22        * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
     23        (WI.ScopeChainDetailsSidebarPanel.prototype.closed):
     24        * UserInterface/Views/TimelineOverview.js:
     25        (WI.TimelineOverview.prototype.closed):
     26
    1272017-10-09  Joseph Pecoraro  <pecoraro@apple.com>
    228

  • trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js

    r220119 r223137  
    7171
    7272        this.needsLayout();
     73    }
     74
     75    closed()
     76    {
     77        WI.applicationCacheManager.removeEventListener(null, null, this);
     78
     79        super.closed();
    7380    }
    7481

  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js

    r222188 r223137  
    3838
    3939    // Public
     40
     41    closed()
     42    {
     43        WI.domTreeManager.removeEventListener(null, null, this);
     44
     45        super.closed();
     46    }
    4047
    4148    addEventListeners()

  • trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js

    r220119 r223137  
    5757    }
    5858
     59    // Public
     60
     61    closed()
     62    {
     63        WI.debuggerManager.removeEventListener(null, null, this);
     64
     65        super.closed();
     66    }
     67
    5968    // Private
    6069

  • trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

    r223057 r223137  
    143143    }
    144144
     145    closed()
     146    {
     147        WI.logManager.removeEventListener(null, null, this);
     148        WI.Frame.removeEventListener(null, null, this);
     149
     150        super.closed();
     151    }
     152
    145153    didAppendConsoleMessageView(messageView)
    146154    {

  • trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js

    r222485 r223137  
    210210
    211211        this._dataGrid.closed();
     212
     213        WI.Frame.removeEventListener(null, null, this);
    212214    }
    213215

  • trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js

    r220119 r223137  
    8585    }
    8686
     87    closed()
     88    {
     89        WI.probeManager.removeEventListener(null, null, this);
     90
     91        super.closed();
     92    }
     93
    8794    // Protected
    8895

  • trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js

    r221990 r223137  
    9999    }
    100100
     101    closed()
     102    {
     103        WI.Frame.removeEventListener(null, null, this);
     104        WI.debuggerManager.removeEventListener(null, null, this);
     105        WI.runtimeManager.removeEventListener(null, null, this);
     106        WI.targetManager.removeEventListener(null, null, this);
     107        WI.consoleDrawer.removeEventListener(null, null, this);
     108        WI.TabBrowser.removeEventListener(null, null, this);
     109
     110        super.closed();
     111    }
     112
    101113    // Protected
    102114

  • trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js

    r220119 r223137  
    112112    }
    113113
     114    closed()
     115    {
     116        WI.runtimeManager.removeEventListener(null, null, this);
     117        WI.Frame.removeEventListener(null, null, this);
     118        WI.debuggerManager.removeEventListener(null, null, this);
     119
     120        super.closed();
     121    }
     122
    114123    // Protected
    115124

  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

    r220119 r223137  
    363363    }
    364364
     365    closed()
     366    {
     367        WI.timelineManager.removeEventListener(null, null, this);
     368
     369        super.closed();
     370    }
     371
    365372    reset()
    366373    {
Note: See TracChangeset for help on using the changeset viewer.