Changeset 223545 in webkit


Ignore:
Timestamp:
Oct 17, 2017 7:34:41 AM (7 years ago)
Author:
Carlos Garcia Campos
Message:

Merge r221075, r221260 - [WPE] Some event handlers not working.
​https://bugs.webkit.org/show_bug.cgi?id=175864

Reviewed by Michael Catanzaro.

Source/WebCore:

Share the EventHandler implementation with the GTK port and add ifdefs where needed.

Covered by existing tests.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • page/wpe/EventHandlerWPE.cpp: Removed.
  • platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

LayoutTests:

Remove expected failures for tests that now pass, add new expectation
for a test that is failing also on GTK+ and rebaseline a test with
the same expected result than on GTK+.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.
Location:
releases/WebKitGTK/webkit-2.18
Files:
1 added
1 deleted
5 edited
1 moved

Legend:

Unmodified
Added
Removed

  • releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog

    r223535 r223545  
     12017-08-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [WPE] Some event handlers not working.
     4        https://bugs.webkit.org/show_bug.cgi?id=175864
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Remove expected failures for tests that now pass, add new expectation
     9        for a test that is failing also on GTK+ and rebaseline a test with
     10        the same expected result than on GTK+.
     11
     12        * platform/wpe/TestExpectations:
     13        * platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.
     14
    1152017-10-13  Brent Fulgham  <bfulgham@apple.com>
    216

  • releases/WebKitGTK/webkit-2.18/LayoutTests/platform/wpe/TestExpectations

    r220259 r223545  
    383383# Most of them are probably failing because of missing support of event related
    384384# features in WPE.
    385 webkit.org/b/173419 fast/events/autoscroll-in-overflow-hidden-html.html [ Failure ]
    386385webkit.org/b/173419 fast/events/autoscroll-in-textarea.html [ Failure ]
    387386webkit.org/b/173419 fast/events/autoscroll-in-textfield.html [ Failure ]
    … …  
    405404webkit.org/b/173419 fast/events/input-events-paste-rich-datatransfer.html [ Failure ]
    406405webkit.org/b/173419 fast/events/js-keyboard-event-creation.html [ Failure ]
    407 webkit.org/b/173419 fast/events/keydown-1.html [ Failure ]
    408406webkit.org/b/173419 fast/events/keydown-numpad-keys.html [ Failure ]
    409407webkit.org/b/173419 fast/events/mouse-cursor-image-set.html [ Failure ]
    410 webkit.org/b/173419 fast/events/mouse-drag-from-frame-to-other-frame.html [ Failure ]
    411 webkit.org/b/173419 fast/events/mouse-drag-from-frame.html [ Failure ]
    412 webkit.org/b/173419 fast/events/mouseenterleave-on-subframe.html [ Failure ]
    413408webkit.org/b/173419 fast/events/mouseover-button.html [ Failure ]
    414 webkit.org/b/173419 fast/events/mouseover-mouseout.html [ Failure ]
    415 webkit.org/b/173419 fast/events/mouseover-mouseout2.html [ Failure ]
    416409webkit.org/b/173419 fast/events/mouseup-from-button2.html [ Failure ]
    417410webkit.org/b/173419 fast/events/no-scroll-on-input-text-selection.html [ Failure ]
    … …  
    420413webkit.org/b/173419 fast/events/onchange-range-slider.html [ Failure ]
    421414webkit.org/b/173419 fast/events/option-tab.html [ Failure ]
    422 webkit.org/b/173419 fast/events/page-scaled-mouse-click-iframe.html [ Failure ]
    423415webkit.org/b/173419 fast/events/platform-wheelevent-in-scrolling-div.html [ Failure ]
    424416webkit.org/b/173419 fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html [ Failure ]
    … …  
    454446webkit.org/b/173419 fast/events/autoscroll-when-zoomed.html [ Timeout ]
    455447webkit.org/b/173419 fast/events/before-input-prevent-insert-replacement.html [ Timeout ]
    456 webkit.org/b/173419 fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html [ Timeout ]
    457448webkit.org/b/173419 fast/events/clipboard-dataTransferItemList.html [ Timeout ]
    458449webkit.org/b/173419 fast/events/drag-dataTransferItemList.html [ Timeout ]
    459450webkit.org/b/173419 fast/events/event-view-toString.html [ Timeout ]
    460 webkit.org/b/173419 fast/events/frame-detached-in-mousedown.html [ Timeout ]
    461 webkit.org/b/173419 fast/events/iframe-onmousemove.html [ Timeout ]
    462451webkit.org/b/173419 fast/events/input-event-insert-replacement.html [ Timeout ]
    463452webkit.org/b/173419 fast/events/mouse-force-changed.html [ Timeout ]
    464453webkit.org/b/173419 fast/events/mouse-force-down.html [ Timeout ]
    465454webkit.org/b/173419 fast/events/mouse-force-up.html [ Timeout ]
    466 webkit.org/b/173419 fast/events/mouse-moved-remove-frame-crash.html [ Timeout ]
    467455webkit.org/b/173419 fast/events/page-visibility-iframe-delete-test.html [ Timeout ]
    468456webkit.org/b/173419 fast/events/page-visibility-iframe-move-test.html [ Timeout ]
    … …  
    470458webkit.org/b/173419 fast/events/page-visibility-onvisibilitychange.html [ Timeout ]
    471459webkit.org/b/173419 fast/events/page-visibility-transition-test.html [ Timeout ]
    472 webkit.org/b/173419 fast/events/popup-blocking-click-in-iframe.html [ Timeout ]
    473460webkit.org/b/173419 fast/events/scroll-after-click-on-tab-index.html [ Timeout ]
    474461webkit.org/b/173419 fast/events/standalone-image-drag-to-editable.html [ Timeout ]
    475 webkit.org/b/173419 fast/events/touch/emulated-touch-iframe.html [ Timeout ]
    476462webkit.org/b/173419 fast/events/touch/multi-touch-grouped-targets.html [ Timeout ]
    477463webkit.org/b/173419 fast/events/touch/multi-touch-inside-nested-iframes.html [ Timeout ]
    … …  
    479465webkit.org/b/173419 fast/events/touch/touch-target-limited.html [ Timeout ]
    480466webkit.org/b/173419 fast/events/touch/touch-target.html [ Timeout ]
    481 webkit.org/b/173419 fast/events/wheel-event-destroys-frame.html [ Timeout ]
     467
     468webkit.org/b/173411 fast/events/touch/frame-hover-update.html [ Failure ]
    482469
    483470fast/events/ios [ Skip ]

  • releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog

    r223541 r223545  
     12017-08-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
     4        https://bugs.webkit.org/show_bug.cgi?id=175864
     5
     6        Unreviewed cosmetic follow-up patch after r221075.
     7
     8        No new tests. No change in behavior.
     9
     10        * PlatformGTK.cmake:
     11        * PlatformWPE.cmake:
     12        * platform/glib/EventHandlerGLib.cpp: Renamed from Source/WebCore/platform/glib/EventHandlerGlib.cpp.
     13        (WebCore::EventHandler::tabsToAllFormControls const):
     14        (WebCore::EventHandler::focusDocumentView):
     15        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
     16        (WebCore::EventHandler::passMouseDownEventToWidget):
     17        (WebCore::EventHandler::eventActivatedView const):
     18        (WebCore::EventHandler::widgetDidHandleWheelEvent):
     19        (WebCore::EventHandler::createDraggingDataTransfer const):
     20        (WebCore::EventHandler::passMousePressEventToSubframe):
     21        (WebCore::EventHandler::passMouseMoveEventToSubframe):
     22        (WebCore::EventHandler::passMouseReleaseEventToSubframe):
     23        (WebCore::EventHandler::accessKeyModifiers):
     24        (WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):
     25
     262017-08-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     27
     28        [WPE] Some event handlers not working.
     29        https://bugs.webkit.org/show_bug.cgi?id=175864
     30
     31        Reviewed by Michael Catanzaro.
     32
     33        Share the EventHandler implementation with the GTK port and add ifdefs where needed.
     34
     35        Covered by existing tests.
     36
     37        * PlatformGTK.cmake:
     38        * PlatformWPE.cmake:
     39        * page/wpe/EventHandlerWPE.cpp: Removed.
     40        * platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.
     41        (WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):
     42
    1432017-10-16  Maureen Daum  <mdaum@apple.com>
    244

  • releases/WebKitGTK/webkit-2.18/Source/WebCore/PlatformGTK.cmake

    r223490 r223545  
    155155
    156156    page/gtk/DragControllerGtk.cpp
    157     page/gtk/EventHandlerGtk.cpp
     157
     158    platform/glib/EventHandlerGLib.cpp
    158159
    159160    platform/graphics/PlatformDisplay.cpp

  • releases/WebKitGTK/webkit-2.18/Source/WebCore/PlatformWPE.cmake

    r223494 r223545  
    136136    editing/wpe/EditorWPE.cpp
    137137
    138     page/wpe/EventHandlerWPE.cpp
     138    platform/glib/EventHandlerGLib.cpp
    139139
    140140    platform/graphics/egl/GLContextEGLWPE.cpp

  • releases/WebKitGTK/webkit-2.18/Source/WebCore/platform/glib/EventHandlerGLib.cpp

    r223544 r223545  
    11/*
    22 * Copyright (C) 2006 Zack Rusin <zack@kde.org>
     3 * Copyright (C) 2014-2017 Igalia S.L.
    34 *
    45 * Redistribution and use in source and binary forms, with or without
    … …  
    2728#include "EventHandler.h"
    2829
    29 #include "DataTransfer.h"
    30 #include "FloatPoint.h"
    3130#include "FocusController.h"
    3231#include "Frame.h"
    … …  
    3938#include "PlatformWheelEvent.h"
    4039#include "RenderWidget.h"
     40
     41#if ENABLE(DRAG_SUPPORT)
     42#include "DataTransfer.h"
     43#endif
     44
     45#if PLATFORM(GTK)
    4146#include "Scrollbar.h"
     47#endif
    4248
    4349namespace WebCore {
    … …  
    8187bool EventHandler::eventActivatedView(const PlatformMouseEvent&) const
    8288{
    83     //GTK+ activation is not necessarily tied to mouse events, so it may
    84     //not make sense to implement this
     89    // GTK+ activation is not necessarily tied to mouse events, so it may
     90    // not make sense to implement this
    8591
    8692    notImplemented();
    … …  
    134140bool EventHandler::shouldTurnVerticalTicksIntoHorizontal(const HitTestResult& result, const PlatformWheelEvent& event) const
    135141{
     142#if PLATFORM(GTK)
    136143    FrameView* view = m_frame.view();
    137144    Scrollbar* scrollbar = view ? view->scrollbarAtPoint(event.position()) : nullptr;
    … …  
    139146        scrollbar = result.scrollbar();
    140147    return scrollbar && scrollbar->orientation() == HorizontalScrollbar;
     148#else
     149    UNUSED_PARAM(result);
     150    UNUSED_PARAM(event);
     151    notImplemented();
     152    return false;
     153#endif
    141154}
    142155
Note: See TracChangeset for help on using the changeset viewer.