Changeset 224604 in webkit

Timestamp:

Nov 8, 2017 3:54:15 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=179442

Reviewed by Simon Fraser.

Disable the assertion when the web thread is used.

• dom/Document.cpp:

(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayout):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-11-08  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded
+        https://bugs.webkit.org/show_bug.cgi?id=179442
+
+        Reviewed by Simon Fraser.
+
+        Disable the assertion when the web thread is used.
+
+        * dom/Document.cpp:
+        (WebCore::Document::updateStyleIfNeeded):
+        (WebCore::Document::updateLayout):
+
 2017-11-08  Colin Bendell  <colin@bendell.ca>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -1940 +1940 @@
 
     // The early exit for needsStyleRecalc() is needed when updateWidgetPositions() is called in runOrScheduleAsynchronousTasks().
+#if !USE(WEB_THREAD)
     RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()));
+#endif
 
     resolveStyle();
@@ -1957 +1959 @@
         return;
     }
+#if !USE(WEB_THREAD)
     RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()));
-
+#endif
 
     RenderView::RepaintRegionAccumulator repaintRegionAccumulator(renderView());