Changeset 226152 in webkit

Timestamp:

Dec 19, 2017 3:50:04 PM (6 years ago)

Author:

BJ Burg

Message:

SLEEP_THREAD_FOR_DEBUGGER() macro should try to print out the PID of the affected process
​https://bugs.webkit.org/show_bug.cgi?id=180947

Reviewed by Joseph Pecoraro.

• wtf/DebugUtilities.h:
• Use sleep() from CurrentTime.h as it is more cross-platform.
• Print a message with the process PID to simplify attaching to sleeping thread.
• Include source location in case multiple such macros are being used.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/DebugUtilities.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2017-12-19  Brian Burg  <bburg@apple.com>
+
+        SLEEP_THREAD_FOR_DEBUGGER() macro should try to print out the PID of the affected process
+        https://bugs.webkit.org/show_bug.cgi?id=180947
+
+        Reviewed by Joseph Pecoraro.
+
+        * wtf/DebugUtilities.h:
+        - Use sleep() from CurrentTime.h as it is more cross-platform.
+        - Print a message with the process PID to simplify attaching to sleeping thread.
+        - Include source location in case multiple such macros are being used.
+
 2017-12-18  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WTF/wtf/DebugUtilities.h

@@ -28 +28 @@
 
 #include <wtf/Assertions.h>
+#include <wtf/CurrentTime.h>
+#include <wtf/ProcessID.h>
 
 #define SLEEP_THREAD_FOR_DEBUGGER() \
 do { \
     do { \
-        sleep(1); \
+        sleep(1.0); \
         if (WTFIsDebuggerAttached()) \
             break; \
     } while (1); \
+    WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, "Sleeping thread for debugger; attach to process (PID: %d) to unsleep the thread.", getCurrentProcessID()); \
     WTFBreakpointTrap(); \
 } while (0)