Changeset 226802 in webkit


Ignore:
Timestamp:
Jan 11, 2018 1:45:58 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

window.visualViewport should behave as [SameObject]
​https://bugs.webkit.org/show_bug.cgi?id=181548

Patch by Ali Juma <​ajuma@chromium.org> on 2018-01-11
Reviewed by Chris Dumez.

Source/WebCore:

Add 'GenerateIsReachable' to VisualViewport so that window.visualViewport's
JS wrapper object doesn't get garbage collected too soon.

Test: fast/visual-viewport/visual-viewport-same-object.html

  • page/VisualViewport.idl:

LayoutTests:

  • fast/visual-viewport/visual-viewport-same-object-expected.txt: Added.
  • fast/visual-viewport/visual-viewport-same-object.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r226801 r226802  
     12018-01-11  Ali Juma  <ajuma@chromium.org>
     2
     3        window.visualViewport should behave as [SameObject]
     4        https://bugs.webkit.org/show_bug.cgi?id=181548
     5
     6        Reviewed by Chris Dumez.
     7
     8        * fast/visual-viewport/visual-viewport-same-object-expected.txt: Added.
     9        * fast/visual-viewport/visual-viewport-same-object.html: Added.
     10
    1112018-01-11  Youenn Fablet  <youenn@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r226800 r226802  
     12018-01-11  Ali Juma  <ajuma@chromium.org>
     2
     3        window.visualViewport should behave as [SameObject]
     4        https://bugs.webkit.org/show_bug.cgi?id=181548
     5
     6        Reviewed by Chris Dumez.
     7
     8        Add 'GenerateIsReachable' to VisualViewport so that window.visualViewport's
     9        JS wrapper object doesn't get garbage collected too soon.
     10
     11        Test: fast/visual-viewport/visual-viewport-same-object.html
     12
     13        * page/VisualViewport.idl:
     14
    1152018-01-11  Basuke Suzuki  <Basuke.Suzuki@sony.com>
    216

  • trunk/Source/WebCore/page/VisualViewport.idl

    r225103 r226802  
    2626// https://wicg.github.io/ViewportAPI/spec.html
    2727[
    28 EnabledBySetting=VisualViewportAPI
     28EnabledBySetting=VisualViewportAPI,
     29GenerateIsReachable=ImplFrame
    2930]
    3031interface VisualViewport : EventTarget {
Note: See TracChangeset for help on using the changeset viewer.