Changeset 227782 in webkit

Timestamp:

Jan 30, 2018, 5:29:32 AM (9 years ago)

Author:

Carlos Garcia Campos

Message:

Unreviewed. Try to avoid webdriver tests step timing out in the bots.

The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.

• Scripts/run-webdriver-tests:
• Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner.dump_results_to_json_file):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-webdriver-tests (modified) (1 diff)
• Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Unreviewed. Try to avoid webdriver tests step timing out in the bots.
+
+        The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
+        after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
+        file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
+        creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
+
+        * Scripts/run-webdriver-tests:
+        * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
+        (WebDriverTestRunner.dump_results_to_json_file):
+
 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
 

trunk/Tools/Scripts/run-webdriver-tests

@@ -75 +75 @@
         print '***'
 
+if options.json_output is not None:
+    # Create the json output file now, because buildbot watches it and it seems
+    # that creating it a t once after the tests causes problems.
+    directory = os.path.dirname(options.json_output)
+    if directory and not os.path.exists(directory):
+        os.makedirs(directory)
+    open(options.json_output, 'wb').close()
+
 port._display_server = options.display_server
 runner = WebDriverTestRunner(port)

trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py

@@ -153 +153 @@
             json_results['results'].append(results)
 
-        directory = os.path.dirname(output_path)
-        if directory and not os.path.exists(directory):
-            os.makedirs(directory)
-
         with open(output_path, 'wb') as fp:
             json.dump(json_results, fp)