Changeset 228001 in webkit

Timestamp:

Feb 2, 2018 2:53:30 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] fast/events/message-channel-gc-4.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=182104

Patch by Fujii Hironori <Fujii Hironori> on 2018-02-02
Reviewed by Carlos Garcia Campos.

Source/WTF:

RELEASE_ASSERT of ThreadSpecific::set fails because
RunLoop::current is called even in GC thread since r227275.

• wtf/RunLoop.cpp:

(WTF::RunLoop::current):
Let the second template argument of ThreadSpecific CanBeGCThread::True.

LayoutTests:

• platform/gtk/TestExpectations:

Unmarked fast/events/message-channel-gc-4.html and fast/workers/worker-cloneport.html.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/RunLoop.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-02-02  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [GTK] fast/events/message-channel-gc-4.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=182104
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/gtk/TestExpectations:
+        Unmarked fast/events/message-channel-gc-4.html and fast/workers/worker-cloneport.html.
+
 2018-02-01  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1920 +1920 @@
 webkit.org/b/181767 fast/hidpi/filters-hue-rotate.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/182104 fast/events/message-channel-gc-4.html [ Pass Crash ]
-
-webkit.org/b/182105 fast/workers/worker-cloneport.html [ Pass Crash ]
-
 webkit.org/b/179947 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-auto-dir-default.html [ Pass Timeout ]
 webkit.org/b/182364 imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html [ Pass Timeout Crash ]

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-02-02  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [GTK] fast/events/message-channel-gc-4.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=182104
+
+        Reviewed by Carlos Garcia Campos.
+
+        RELEASE_ASSERT of ThreadSpecific::set fails because
+        RunLoop::current is called even in GC thread since r227275.
+
+        * wtf/RunLoop.cpp:
+        (WTF::RunLoop::current):
+        Let the second template argument of ThreadSpecific CanBeGCThread::True.
+
 2018-02-01  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WTF/wtf/RunLoop.cpp

@@ -59 +59 @@
 RunLoop& RunLoop::current()
 {
-    static NeverDestroyed<ThreadSpecific<Holder>> runLoopHolder;
+    static NeverDestroyed<ThreadSpecific<Holder, CanBeGCThread::True>> runLoopHolder;
     return runLoopHolder.get()->runLoop();
 }