Changeset 228006 in webkit

Timestamp:

Feb 2, 2018 5:54:14 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r227964.
​https://bugs.webkit.org/show_bug.cgi?id=182423

It broke several unit tests (Requested by KaL on #webkit).

Reverted changeset:

"[SOUP] Ensure domain is valid when converting a WebCore
Cookie to Soup"
​https://bugs.webkit.org/show_bug.cgi?id=182328
​https://trac.webkit.org/changeset/227964

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/CookieSoup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-02  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r227964.
+        https://bugs.webkit.org/show_bug.cgi?id=182423
+
+        It broke several unit tests (Requested by KaL on #webkit).
+
+        Reverted changeset:
+
+        "[SOUP] Ensure domain is valid when converting a WebCore
+        Cookie to Soup"
+        https://bugs.webkit.org/show_bug.cgi?id=182328
+        https://trac.webkit.org/changeset/227964
+
 2018-02-01  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/network/soup/CookieSoup.cpp

@@ -61 +61 @@
         return nullptr;
 
-    // soup_cookie_new() will handle the given domain as a hostname if it doesn't start with '.'.
-    auto cookieDomain = domain.utf8();
-    if (cookieDomain.length() && !g_hostname_is_ip_address(cookieDomain.data()) && cookieDomain.data()[0] != '.')
-        cookieDomain = makeString('.', domain).utf8();
-
     SoupCookie* soupCookie = soup_cookie_new(name.utf8().data(), value.utf8().data(),
-        cookieDomain.data(), path.utf8().data(), -1);
+        domain.utf8().data(), path.utf8().data(), -1);
 
     soup_cookie_set_http_only(soupCookie, httpOnly);