Changeset 228034 in webkit

Timestamp:

Feb 2, 2018 4:39:31 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Clearing all service worker registrations should wait for importing service worker registration to finish
​https://bugs.webkit.org/show_bug.cgi?id=182407
<rdar://problem/37167523>

Patch by Youenn Fablet <​youenn@apple.com> on 2018-02-02
Reviewed by Chris Dumez.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::clear): ensure completion handler is called on early exit case.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/service/server/SWServer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-02  Youenn Fablet  <youenn@apple.com>
+
+        Clearing all service worker registrations should wait for importing service worker registration to finish
+        https://bugs.webkit.org/show_bug.cgi?id=182407
+        <rdar://problem/37167523>
+
+        Reviewed by Chris Dumez.
+
+        * workers/service/server/SWServer.cpp:
+        (WebCore::SWServer::clear): ensure completion handler is called on early exit case.
+
 2018-02-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/workers/service/server/SWServer.cpp

@@ -231 +231 @@
     });
 
-    if (registrationsToRemove.isEmpty())
-        return;
+    if (registrationsToRemove.isEmpty()) {
+        completionHandler();
+        return;
+    }
 
     // Calling SWServerRegistration::clear() takes care of updating m_registrations, m_originStore and m_registrationStore.