Changeset 228296 in webkit

Timestamp:

Feb 8, 2018 3:18:28 PM (6 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Styles: Typing value and quickly moving focus away may display outdated value in UI
​https://bugs.webkit.org/show_bug.cgi?id=182588
<rdar://problem/37332161>

Reviewed by Matt Baker.

CSSProperty models were updated with a 250ms delay. Quickly adding a blank property after modifying
an existing property could result in outdated values being shown.

This patch removes the 250ms delay.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidChange):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SpreadsheetStyleProperty.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-02-08  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Styles: Typing value and quickly moving focus away may display outdated value in UI
+        https://bugs.webkit.org/show_bug.cgi?id=182588
+        <rdar://problem/37332161>
+
+        Reviewed by Matt Baker.
+
+        CSSProperty models were updated with a 250ms delay. Quickly adding a blank property after modifying
+        an existing property could result in outdated values being shown.
+
+        This patch removes the 250ms delay.
+
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidChange):
+
 2018-02-07  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js

@@ -248 +248 @@
     {
         if (textField === this._valueTextField)
-            this.debounce(WI.SpreadsheetStyleProperty.CommitCoalesceDelay)._handleValueChange();
+            this._handleValueChange();
         else if (textField === this._nameTextField)
-            this.debounce(WI.SpreadsheetStyleProperty.CommitCoalesceDelay)._handleNameChange();
+            this._handleNameChange();
     }
 
@@ -667 +667 @@
 
 WI.SpreadsheetStyleProperty.StyleClassName = "property";
-
-WI.SpreadsheetStyleProperty.CommitCoalesceDelay = 250;