Changeset 228341 in webkit

Timestamp:

Feb 9, 2018 3:56:41 PM (6 years ago)

Author:

Brent Fulgham

Message:

Sandbox violating attempting to read log formatting preference file
​https://bugs.webkit.org/show_bug.cgi?id=182648
<rdar://problem/36629495>

Reviewed by Eric Carlson.

Various frameworks attempt to read logging format information from /usr/local/lib/log. The sandbox is blocking
this, generating log spam and preventing some logging features from working properly. We should allow read
access to this path.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (modified) (1 diff)
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (modified) (1 diff)
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (modified) (1 diff)
• WebProcess/com.apple.WebProcess.sb.in (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-02-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Sandbox violating attempting to read log formatting preference file
+        https://bugs.webkit.org/show_bug.cgi?id=182648
+        <rdar://problem/36629495>
+
+        Reviewed by Eric Carlson.
+
+        Various frameworks attempt to read logging format information from /usr/local/lib/log. The sandbox is blocking
+        this, generating log spam and preventing some logging features from working properly. We should allow read
+        access to this path.
+
+        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+        * WebProcess/com.apple.WebProcess.sb.in:
+
 2018-02-08  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in

@@ -110 +110 @@
     (subpath (param "WEBKIT2_FRAMEWORK_DIR")))
 (allow system-fsctl (fsctl-command (_IO "h" 47)))
+
+(allow file-read-data
+    (literal "/usr/local/lib/log") ; <rdar://problem/36629495>
+)
 
 ;; Sandbox extensions

trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb

@@ -67 +67 @@
     "/systemgroup.com.apple.nsurlstoragedresources/Library/dafsaData.bin")
 
+(allow file-read-data
+    (literal "/usr/local/lib/log") ; <rdar://problem/36629495>
+)
+
 ;; Security framework
 (allow mach-lookup

trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

@@ -371 +371 @@
 (allow file-read* (literal "/private/var/Managed Preferences/mobile/com.apple.webcontentfilter.plist"))
 
+(allow file-read-data
+    (literal "/usr/local/lib/log") ; <rdar://problem/36629495>
+)
+
 ;; Allow mediaserverd to issue file extensions for the purposes of reading media
 (allow file-issue-extension (require-all

trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

@@ -440 +440 @@
 
 (allow file-read-data
+    (literal "/usr/local/lib/log") ; <rdar://problem/36629495>
     ;; Needed for AES3 support
     (subpath "/Library/Audio/Plug-Ins/Components"))