Changeset 228351 in webkit

Timestamp:

Feb 9, 2018 8:44:39 PM (6 years ago)

Author:

Ross Kirsling

Message:

Remove invalidated WebPage::handleEditingKeyboardEvent default implementation after r228260.
​https://bugs.webkit.org/show_bug.cgi?id=182663

Reviewed by Chris Dumez.

This would need to be updated to turn keyEvent into underlyingPlatformEvent;
instead, we can remove it, as it's only for Windows, which doesn't yet support WK2.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleEditingKeyboardEvent): Deleted.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Remove invalidated WebPage::handleEditingKeyboardEvent default implementation after r228260.
+        https://bugs.webkit.org/show_bug.cgi?id=182663
+
+        Reviewed by Chris Dumez.
+
+        This would need to be updated to turn `keyEvent` into `underlyingPlatformEvent`;
+        instead, we can remove it, as it's only for Windows, which doesn't yet support WK2.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::handleEditingKeyboardEvent): Deleted.
+
 2018-02-09  Nan Wang  <n_wang@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -3298 +3298 @@
 }
 
-#if !PLATFORM(GTK) && !PLATFORM(COCOA) && !PLATFORM(WPE)
-
-bool WebPage::handleEditingKeyboardEvent(KeyboardEvent* evt)
-{
-    Frame* frame = downcast<Node>(*evt->target()).document().frame();
-    ASSERT(frame);
-
-    const PlatformKeyboardEvent* keyEvent = evt->keyEvent();
-    if (!keyEvent)
-        return false;
-
-    Editor::Command command = frame->editor().command(interpretKeyEvent(evt));
-
-    if (keyEvent->type() == PlatformEvent::RawKeyDown) {
-        // WebKit doesn't have enough information about mode to decide how commands that just insert text if executed via Editor should be treated,
-        // so we leave it upon WebCore to either handle them immediately (e.g. Tab that changes focus) or let a keypress event be generated
-        // (e.g. Tab that inserts a Tab character, or Enter).
-        return !command.isTextInsertion() && command.execute(evt);
-    }
-
-    if (command.execute(evt))
-        return true;
-
-    // Don't allow text insertion for nodes that cannot edit.
-    if (!frame->editor().canEdit())
-        return false;
-
-    // Don't insert null or control characters as they can result in unexpected behaviour
-    if (evt->charCode() < ' ')
-        return false;
-
-    return frame->editor().insertText(evt->keyEvent()->text(), evt);
-}
-
-#endif
-
 #if ENABLE(DRAG_SUPPORT)