Changeset 228359 in webkit
- Timestamp:
- Feb 9, 2018 9:43:52 PM (6 years ago)
- Location:
- branches/safari-605-branch/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
branches/safari-605-branch/Source/WebCore/ChangeLog
r228358 r228359 1 2018-02-09 Jason Marcell <jmarcell@apple.com> 2 3 Cherry-pick r228342. rdar://problem/37408891 4 5 2018-02-09 Andy Estes <aestes@apple.com> 6 7 [Payment Request] Apple Pay sheet does not dismiss when calling complete() with result "unknown" or "fail" 8 https://bugs.webkit.org/show_bug.cgi?id=182658 9 <rdar://problem/37293917> 10 11 Reviewed by Brady Eidson. 12 13 When PaymentResponse::complete() is called with a result of "unknown" or "fail", we should 14 treat this as a fatal error and dismiss the Apple Pay sheet. However, we were adding an 15 error with code "unknown" to the authorization result, which PassKit interprets as a 16 non-fatal error. Instead, we should not set any errors and just use a status code of 17 PaymentAuthorizationStatus::Failure, which PassKit interprets as a fatal error, dismissing 18 the sheet. 19 20 No test possible. 21 22 * Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp: 23 (WebCore::ApplePayPaymentHandler::complete): 24 1 25 2018-02-09 Jason Marcell <jmarcell@apple.com> 2 26 -
branches/safari-605-branch/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
r228207 r228359 410 410 case PaymentComplete::Unknown: 411 411 authorizationResult.status = PaymentAuthorizationStatus::Failure; 412 authorizationResult.errors.append({ PaymentError::Code::Unknown, { }, std::nullopt });413 412 break; 414 413 case PaymentComplete::Success:
Note: See TracChangeset
for help on using the changeset viewer.