Changeset 228361 in webkit

Timestamp:

Feb 9, 2018 10:14:52 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

Make run-perf-tests work with Speedometer 2.0 and re-enable the test
​https://bugs.webkit.org/show_bug.cgi?id=182088

Reviewed by Antti Koivisto.

This patch updates the test harness to report new metrics of Speedometer 2.0.

Replaced the total time by the geometric mean of the time spent in each suite, and added scores
as a metric in addition to time. Also, updated the PerfTestRunner harness and the results template
to support "Score" metric with "pt" as its unit.

• Skipped: Unskipped the test.
• Speedometer/resources/benchmark-report.js:

(window.benchmarkClient.willStartFirstIteration..createTest): Added the unit as an optional argument
to report the score in addition to time. Also report the geomean of time instead of the total time.
(window.benchmarkClient.willStartFirstIteration): Report the geomean of time.
(window.benchmarkClient.didRunSuites): Record the entire measuredValues instead of just tests.
(window.benchmarkClient.didFinishLastIteration): Report the scores.

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• Skipped (modified) (1 diff)
• Speedometer/resources/benchmark-report.js (modified) (4 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2018-02-09  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Make run-perf-tests work with Speedometer 2.0 and re-enable the test
+        https://bugs.webkit.org/show_bug.cgi?id=182088
+
+        Reviewed by Antti Koivisto.
+
+        This patch updates the test harness to report new metrics of Speedometer 2.0.
+
+        Replaced the total time by the geometric mean of the time spent in each suite, and added scores
+        as a metric in addition to time. Also, updated the PerfTestRunner harness and the results template
+        to support "Score" metric with "pt" as its unit.
+
+        * Skipped: Unskipped the test.
+        * Speedometer/resources/benchmark-report.js:
+        (window.benchmarkClient.willStartFirstIteration..createTest): Added the unit as an optional argument
+        to report the score in addition to time. Also report the geomean of time instead of the total time.
+        (window.benchmarkClient.willStartFirstIteration): Report the geomean of time.
+        (window.benchmarkClient.didRunSuites): Record the entire measuredValues instead of just tests.
+        (window.benchmarkClient.didFinishLastIteration): Report the scores.
+
 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/PerformanceTests/Skipped

@@ -83 +83 @@
 
 # Don't run the interactive runner. We run index.html
-Speedometer/index.html
 Speedometer/InteractiveRunner.html
 StyleBench/InteractiveRunner.html

trunk/PerformanceTests/Speedometer/resources/benchmark-report.js

@@ -27 +27 @@
         iterationCount: 5, // Use 4 different instances of DRT/WTR to run 5 iterations.
         willStartFirstIteration: function (iterationCount) {
-            createTest = function (name, aggregator, isLastTest) {
+            createTest = function (name, aggregator, isLastTest, unit = 'ms') {
                 return {
                     customIterationCount: iterationCount,
@@ -33 +33 @@
                     doNotMeasureMemoryUsage: true,
                     continueTesting: !isLastTest,
-                    unit: 'ms',
+                    unit: unit,
                     name: name,
                     aggregator: aggregator};
             }
-            PerfTestRunner.prepareToMeasureValuesAsync(createTest(null, 'Total'));
+            PerfTestRunner.prepareToMeasureValuesAsync(createTest(null, 'Geometric'));
         },
         didRunSuites: function (measuredValues) {
-            PerfTestRunner.measureValueAsync(measuredValues.total);
-            valuesByIteration.push(measuredValues.tests);
+            PerfTestRunner.measureValueAsync(measuredValues.geomean);
+            valuesByIteration.push(measuredValues);
         },
         didFinishLastIteration: function () {
@@ -54 +54 @@
             }
 
+            var scores = [];
             valuesByIteration.forEach(function (measuredValues) {
-                for (var suiteName in measuredValues) {
-                    var suite = measuredValues[suiteName];
+                scores.push(measuredValues.score);
+                for (var suiteName in measuredValues.tests) {
+                    var suite = measuredValues.tests[suiteName];
                     for (var testName in suite.tests) {
                         var test = suite.tests[testName];
@@ -66 +68 @@
                 }
             });
+
+            PerfTestRunner.reportValues(createTest(null, null, false, 'pt'), scores);
 
             var fullNames = new Array;