Changeset 228418 in webkit

Timestamp:

Feb 13, 2018 4:11:33 AM (6 years ago)

Author:

aboya@igalia.com

Message:

[Gstreamer][MSE] Add string representation for GStreamerMediaSample
​https://bugs.webkit.org/show_bug.cgi?id=180262

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:

(WebCore::GStreamerMediaSample::offsetTimestampsBy):

• platform/graphics/gstreamer/mse/GStreamerMediaSample.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaSampleGStreamer.cpp (modified) (1 diff)
• platform/graphics/gstreamer/MediaSampleGStreamer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-13  Alicia Boya García  <aboya@igalia.com>
+
+        [Gstreamer][MSE] Add string representation for GStreamerMediaSample
+        https://bugs.webkit.org/show_bug.cgi?id=180262
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:
+        (WebCore::GStreamerMediaSample::offsetTimestampsBy):
+        * platform/graphics/gstreamer/mse/GStreamerMediaSample.h:
+
 2018-02-12  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp

@@ -124 +124 @@
 }
 
+void MediaSampleGStreamer::dump(PrintStream& out) const
+{
+    out.print("{PTS(", presentationTime(), "), DTS(", decodeTime(), "), duration(", duration(), "), flags(");
+
+    bool anyFlags = false;
+    auto appendFlag = [&out, &anyFlags](const char* flagName) {
+        if (anyFlags)
+            out.print(",");
+        out.print(flagName);
+        anyFlags = true;
+    };
+
+    if (flags() & MediaSample::IsSync)
+        appendFlag("sync");
+    if (flags() & MediaSample::IsNonDisplaying)
+        appendFlag("non-displaying");
+    if (flags() & MediaSample::HasAlpha)
+        appendFlag("has-alpha");
+    if (flags() & ~(MediaSample::IsSync | MediaSample::IsNonDisplaying | MediaSample::HasAlpha))
+        appendFlag("unknown-flag");
+
+    out.print("), trackId(", trackID().string(), "), presentationSize(", presentationSize().width(), "x", presentationSize().height(), ")}");
+}
+
 } // namespace WebCore.
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h

@@ -54 +54 @@
     SampleFlags flags() const override { return m_flags; }
     PlatformSample platformSample() override;
-    void dump(PrintStream&) const override { }
+    void dump(PrintStream&) const override;
 
 private: