Changeset 228539 in webkit

Timestamp:

Feb 15, 2018, 4:07:23 PM (9 years ago)

Author:

ap@apple.com

Message:

Speed up dSYM generation on build.webkit.org with -gline-tables-only
​https://bugs.webkit.org/show_bug.cgi?id=182841
rdar://problem/34579649

Reviewed by Aakash Jain.

Build speed and binary size improvements are so substantial that I'm willing to make
CI builds less suitable for debugging, which is not a common scenario anyway.
Crash logs will still have line numbers in them.

• BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/steps.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py

@@ -207 +207 @@
             if platform == 'ios':
                 self.setCommand(self.command + ['ONLY_ACTIVE_ARCH=NO'])
-        # Generating dSYM files is slow, but these are needed to have line numbers in crash reports on testers.
-        # Debug builds on Yosemite can't use dSYMs, because crash logs end up unsymbolicated.
-        if platform in ('mac', 'ios') and buildOnly and (self.getProperty('fullPlatform') != "mac-yosemite" or self.getProperty('configuration') != "debug"):
+        if platform in ('mac', 'ios') and buildOnly:
+            # For build-only bots, the expectation is that tests will be run on separate machines,
+            # so we need to package debug info as dSYMs. Only generating line tables makes
+            # this much faster than full debug info, and crash logs still have line numbers.
             self.setCommand(self.command + ['DEBUG_INFORMATION_FORMAT=dwarf-with-dsym'])
+            self.setCommand(self.command + ['CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only'])
 
         appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))

trunk/Tools/ChangeLog

@@ +1 @@
+2018-02-15  Alexey Proskuryakov  <ap@apple.com>
+
+        Speed up dSYM generation on build.webkit.org with -gline-tables-only
+        https://bugs.webkit.org/show_bug.cgi?id=182841
+        rdar://problem/34579649
+
+        Reviewed by Aakash Jain.
+
+        Build speed and binary size improvements are so substantial that I'm willing to make
+        CI builds less suitable for debugging, which is not a common scenario anyway.
+        Crash logs will still have line numbers in them.
+
+        * BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
+
 2018-02-15  Don Olmstead  <don.olmstead@sony.com>