Changeset 228708 in webkit

Timestamp:

Feb 19, 2018 1:03:39 PM (6 years ago)

Author:

Chris Dumez

Message:

CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::TimerBase::~TimerBase
​https://bugs.webkit.org/show_bug.cgi?id=182931
<rdar://problem/37602962>

Reviewed by Antti Koivisto.

Make sure PlatformMediaResource is ThreadSafeRefCounted since it is being
used from several threads in WebCoreNSURLSession. Also make sure it is
always destroyed on the main thread since it ends up destroying a
CachedRawResource object.

No new tests, no known reproduction case.

• platform/graphics/PlatformMediaResourceLoader.h:
• platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask dealloc]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/PlatformMediaResourceLoader.h (modified) (1 diff)
• platform/network/cocoa/WebCoreNSURLSession.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-19  Chris Dumez  <cdumez@apple.com>
+
+        CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::TimerBase::~TimerBase
+        https://bugs.webkit.org/show_bug.cgi?id=182931
+        <rdar://problem/37602962>
+
+        Reviewed by Antti Koivisto.
+
+        Make sure PlatformMediaResource is ThreadSafeRefCounted since it is being
+        used from several threads in WebCoreNSURLSession. Also make sure it is
+        always destroyed on the main thread since it ends up destroying a
+        CachedRawResource object.
+
+        No new tests, no known reproduction case.
+
+        * platform/graphics/PlatformMediaResourceLoader.h:
+        * platform/network/cocoa/WebCoreNSURLSession.mm:
+        (-[WebCoreNSURLSessionDataTask dealloc]):
+
 2018-02-19  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h

@@ -71 +71 @@
 };
 
-class PlatformMediaResource : public RefCounted<PlatformMediaResource> {
+class PlatformMediaResource : public ThreadSafeRefCounted<PlatformMediaResource> {
     WTF_MAKE_NONCOPYABLE(PlatformMediaResource); WTF_MAKE_FAST_ALLOCATED;
 public:

trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm

@@ -540 +540 @@
     [_error release];
     [_taskDescription release];
+    callOnMainThread([resource = WTFMove(_resource)] { });
     [super dealloc];
 }