Changeset 228731 in webkit

Timestamp:

Feb 19, 2018 11:08:00 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=182953

Patch by Fujii Hironori <Fujii Hironori> on 2018-02-19
Reviewed by Carlos Garcia Campos.

• Scripts/webkitpy/port/gtk.py:

(GtkPort._get_crash_log): Removed the code to convert WebProcess name.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
(WTR::TestController::networkProcessName): Ditto.
(WTR::TestController::databaseProcessName): Ditto.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/gtk.py (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
+        https://bugs.webkit.org/show_bug.cgi?id=182953
+
+        Reviewed by Carlos Garcia Campos.
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort._get_crash_log): Removed the code to convert WebProcess name.
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
+        (WTR::TestController::networkProcessName): Ditto.
+        (WTR::TestController::databaseProcessName): Ditto.
+
 2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/gtk.py

@@ -224 +224 @@
 
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than, target_host=None):
-        name = "WebKitWebProcess" if name == "WebProcess" else name
         return GDBCrashLogGenerator(name, pid, newer_than, self._filesystem, self._path_to_driver).generate_crash_log(stdout, stderr)
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -892 +892 @@
 #elif PLATFORM(COCOA)
     return "com.apple.WebKit.WebContent.Development";
+#elif PLATFORM(GTK)
+    return "WebKitWebProcess";
 #else
     return "WebProcess";
@@ -904 +906 @@
 #elif PLATFORM(COCOA)
     return "com.apple.WebKit.Networking.Development";
+#elif PLATFORM(GTK)
+    return "WebKitNetworkProcess";
 #else
     return "NetworkProcess";
@@ -920 +924 @@
 #elif PLATFORM(COCOA)
     return "com.apple.WebKit.Storage.Development";
+#elif PLATFORM(GTK)
+    return "WebKitStorageProcess";
 #else
     return "DatabaseProcess";