Changeset 228948 in webkit
- Timestamp:
- Feb 23, 2018 6:52:45 AM (6 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r228947 r228948 1 2018-02-23 Zalan Bujtas <zalan@apple.com> 2 3 [RenderTreeBuilder] Add WARN_UNUSED_RETURN to detach() 4 https://bugs.webkit.org/show_bug.cgi?id=183073 5 <rdar://problem/37814585> 6 7 Reviewed by Antti Koivisto. 8 9 So that we don't destroy a renderer accidentally. 10 11 * rendering/updating/RenderTreeBuilderBlock.h: 12 * rendering/updating/RenderTreeBuilderRuby.h: 13 * rendering/updating/RenderTreeBuilderSVG.h: 14 1 15 2018-02-22 Antoine Quint <graouts@apple.com> 2 16 -
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.h
r228938 r228948 37 37 void attachIgnoringContinuation(RenderBlock& parent, RenderPtr<RenderObject> child, RenderObject* beforeChild); 38 38 39 RenderPtr<RenderObject> detach(RenderBlock& parent, RenderObject& oldChild) ;40 RenderPtr<RenderObject> detach(RenderBlockFlow& parent, RenderObject& child) ;39 RenderPtr<RenderObject> detach(RenderBlock& parent, RenderObject& oldChild) WARN_UNUSED_RETURN; 40 RenderPtr<RenderObject> detach(RenderBlockFlow& parent, RenderObject& child) WARN_UNUSED_RETURN; 41 41 42 42 void dropAnonymousBoxChild(RenderBlock& parent, RenderBlock& child); -
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h
r228938 r228948 43 43 44 44 void attach(RenderRubyRun& parent, RenderPtr<RenderObject> child, RenderObject* beforeChild); 45 RenderPtr<RenderObject> detach(RenderRubyAsInline& parent, RenderObject& child) ;46 RenderPtr<RenderObject> detach(RenderRubyAsBlock& parent, RenderObject& child) ;47 RenderPtr<RenderObject> detach(RenderRubyRun& parent, RenderObject& child) ;45 RenderPtr<RenderObject> detach(RenderRubyAsInline& parent, RenderObject& child) WARN_UNUSED_RETURN; 46 RenderPtr<RenderObject> detach(RenderRubyAsBlock& parent, RenderObject& child) WARN_UNUSED_RETURN; 47 RenderPtr<RenderObject> detach(RenderRubyRun& parent, RenderObject& child) WARN_UNUSED_RETURN; 48 48 49 49 void moveChildren(RenderRubyBase& from, RenderRubyBase& to); -
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h
r228938 r228948 44 44 void attach(RenderSVGText& parent, RenderPtr<RenderObject> child, RenderObject* beforeChild); 45 45 46 RenderPtr<RenderObject> detach(RenderSVGText& parent, RenderObject& child) ;47 RenderPtr<RenderObject> detach(RenderSVGInline& parent, RenderObject& child) ;48 RenderPtr<RenderObject> detach(RenderSVGContainer& parent, RenderObject& child) ;49 RenderPtr<RenderObject> detach(RenderSVGRoot& parent, RenderObject& child) ;46 RenderPtr<RenderObject> detach(RenderSVGText& parent, RenderObject& child) WARN_UNUSED_RETURN; 47 RenderPtr<RenderObject> detach(RenderSVGInline& parent, RenderObject& child) WARN_UNUSED_RETURN; 48 RenderPtr<RenderObject> detach(RenderSVGContainer& parent, RenderObject& child) WARN_UNUSED_RETURN; 49 RenderPtr<RenderObject> detach(RenderSVGRoot& parent, RenderObject& child) WARN_UNUSED_RETURN; 50 50 51 51 private:
Note: See TracChangeset
for help on using the changeset viewer.