Changeset 229112 in webkit
- Timestamp:
- Feb 28, 2018 4:30:08 PM (6 years ago)
- Location:
- trunk
- Files:
-
- 5 added
- 17 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r229108 r229112 1 2018-02-28 Nan Wang <n_wang@apple.com> 2 3 AX: AOM: Dispatch accessiblesetvalue event 4 https://bugs.webkit.org/show_bug.cgi?id=183021 5 <rdar://problem/37764242> 6 7 Reviewed by Chris Fleizach. 8 9 * accessibility/mac/AOM-event-accessiblesetvalue-expected.txt: Added. 10 * accessibility/mac/AOM-event-accessiblesetvalue.html: Added. 11 * js/dom/dom-static-property-for-in-iteration-expected.txt: 12 1 13 2018-02-28 Chris Dumez <cdumez@apple.com> 2 14 -
trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt
r228827 r229112 136 136 PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a> 137 137 PASS a["onaccessibleclick"] is null 138 PASS a["onaccessiblesetvalue"] is null 138 139 PASS a["oncopy"] is null 139 140 PASS a["oncut"] is null -
trunk/Source/WebCore/CMakeLists.txt
r228662 r229112 439 439 Modules/webvr/VRPose.idl 440 440 Modules/webvr/VRStageParameters.idl 441 442 accessibility/AccessibleSetValueEvent.idl 441 443 442 444 animation/Animatable.idl -
trunk/Source/WebCore/ChangeLog
r229108 r229112 1 2018-02-28 Nan Wang <n_wang@apple.com> 2 3 AX: AOM: Dispatch accessiblesetvalue event 4 https://bugs.webkit.org/show_bug.cgi?id=183021 5 <rdar://problem/37764242> 6 7 Reviewed by Chris Fleizach. 8 9 Accessibility events. 10 Spec: https://wicg.github.io/aom/spec/phase2.html 11 12 Added a new event type AccessibleSetValueEvent. 13 14 Test: accessibility/mac/AOM-event-accessiblesetvalue.html 15 16 * CMakeLists.txt: 17 * DerivedSources.make: 18 * Sources.txt: 19 * WebCore.xcodeproj/project.pbxproj: 20 * accessibility/AccessibilityAllInOne.cpp: 21 * accessibility/AccessibilityNodeObject.cpp: 22 (WebCore::AccessibilityNodeObject::canSetValueAttribute const): 23 * accessibility/AccessibilityObject.cpp: 24 (WebCore::AccessibilityObject::press): 25 (WebCore::AccessibilityObject::dispatchAccessibilityEvent): 26 (WebCore::AccessibilityObject::dispatchAccessibleSetValueEvent): 27 * accessibility/AccessibilityObject.h: 28 * accessibility/AccessibilityRenderObject.cpp: 29 (WebCore::AccessibilityRenderObject::setValue): 30 * accessibility/AccessibilityScrollbar.cpp: 31 (WebCore::AccessibilityScrollbar::setValue): 32 * accessibility/AccessibilitySlider.cpp: 33 (WebCore::AccessibilitySlider::setValue): 34 * accessibility/AccessibleSetValueEvent.cpp: Added. 35 (WebCore::AccessibleSetValueEvent::AccessibleSetValueEvent): 36 * accessibility/AccessibleSetValueEvent.h: Added. 37 (WebCore::AccessibleSetValueEvent::create): 38 (WebCore::AccessibleSetValueEvent::value const): 39 * accessibility/AccessibleSetValueEvent.idl: Added. 40 * dom/Element.idl: 41 * dom/EventNames.h: 42 * dom/EventNames.in: 43 1 44 2018-02-28 Chris Dumez <cdumez@apple.com> 2 45 -
trunk/Source/WebCore/DerivedSources.make
r229081 r229112 361 361 $(WebCore)/Modules/webvr/VRPose.idl \ 362 362 $(WebCore)/Modules/webvr/VRStageParameters.idl \ 363 $(WebCore)/accessibility/AccessibleSetValueEvent.idl \ 363 364 $(WebCore)/animation/Animatable.idl \ 364 365 $(WebCore)/animation/AnimationEffectReadOnly.idl \ -
trunk/Source/WebCore/Sources.txt
r229089 r229112 330 330 accessibility/AccessibilityTree.cpp 331 331 accessibility/AccessibilityTreeItem.cpp 332 accessibility/AccessibleSetValueEvent.cpp 332 333 333 334 animation/AnimationEffectReadOnly.cpp … … 2328 2329 JSAbortSignal.cpp 2329 2330 JSAbstractWorker.cpp 2331 JSAccessibleSetValueEvent.cpp 2330 2332 JSAesCbcCfbParams.cpp 2331 2333 JSAesCtrParams.cpp -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r229079 r229112 3233 3233 A9D248070D757E7D00FDF959 /* JSDOMMimeType.h in Headers */ = {isa = PBXBuildFile; fileRef = A9D248030D757E7D00FDF959 /* JSDOMMimeType.h */; }; 3234 3234 A9D248090D757E7D00FDF959 /* JSDOMMimeTypeArray.h in Headers */ = {isa = PBXBuildFile; fileRef = A9D248050D757E7D00FDF959 /* JSDOMMimeTypeArray.h */; }; 3235 A9F2E0EB20475CDE00512855 /* AccessibleSetValueEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = A9F2E0E820475CDC00512855 /* AccessibleSetValueEvent.h */; }; 3235 3236 AA12DF491743DF83004DAFDF /* PlatformSpeechSynthesizerIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = AAE3755D17429BCC006200C2 /* PlatformSpeechSynthesizerIOS.mm */; }; 3236 3237 AA21ECCD0ABF0FC6002B834C /* CSSCursorImageValue.h in Headers */ = {isa = PBXBuildFile; fileRef = AA0978EE0ABAA6E100874480 /* CSSCursorImageValue.h */; settings = {ATTRIBUTES = (Private, ); }; }; … … 11570 11571 A9D248040D757E7D00FDF959 /* JSDOMMimeTypeArray.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMMimeTypeArray.cpp; sourceTree = "<group>"; }; 11571 11572 A9D248050D757E7D00FDF959 /* JSDOMMimeTypeArray.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSDOMMimeTypeArray.h; sourceTree = "<group>"; }; 11573 A9F2E0E720475CDC00512855 /* AccessibleSetValueEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AccessibleSetValueEvent.cpp; sourceTree = "<group>"; }; 11574 A9F2E0E820475CDC00512855 /* AccessibleSetValueEvent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibleSetValueEvent.h; sourceTree = "<group>"; }; 11575 A9F2E0E920475CDE00512855 /* AccessibleSetValueEvent.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = AccessibleSetValueEvent.idl; sourceTree = "<group>"; }; 11572 11576 AA0978ED0ABAA6E100874480 /* CSSCursorImageValue.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = CSSCursorImageValue.cpp; sourceTree = "<group>"; }; 11573 11577 AA0978EE0ABAA6E100874480 /* CSSCursorImageValue.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = CSSCursorImageValue.h; sourceTree = "<group>"; }; … … 16249 16253 A91C9FC01B659A6700AFFD54 /* AccessibilityTreeItem.cpp */, 16250 16254 A91C9FC11B659A6700AFFD54 /* AccessibilityTreeItem.h */, 16255 A9F2E0E720475CDC00512855 /* AccessibleSetValueEvent.cpp */, 16256 A9F2E0E820475CDC00512855 /* AccessibleSetValueEvent.h */, 16257 A9F2E0E920475CDE00512855 /* AccessibleSetValueEvent.idl */, 16251 16258 2981CAAF131822EC00D12F2A /* AXObjectCache.cpp */, 16252 16259 29A8121A0FBB9C1D00510293 /* AXObjectCache.h */, … … 27022 27029 9746AF2114F4DDE6003E7A71 /* Coordinates.h in Headers */, 27023 27030 3F8020351E9E47BF00DEC61D /* CoreAudioCaptureDevice.h in Headers */, 27031 A9F2E0EB20475CDE00512855 /* AccessibleSetValueEvent.h in Headers */, 27024 27032 3F8020371E9E47C500DEC61D /* CoreAudioCaptureDeviceManager.h in Headers */, 27025 27033 07AFF4221EFB144900B545B3 /* CoreAudioCaptureSourceIOS.h in Headers */, -
trunk/Source/WebCore/accessibility/AccessibilityAllInOne.cpp
r228427 r229112 59 59 #include "AccessibilityTree.cpp" 60 60 #include "AccessibilityTreeItem.cpp" 61 #include "AccessibleSetValueEvent.cpp" -
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
r228427 r229112 2084 2084 return false; 2085 2085 2086 if (isProgressIndicator() || isSlider() )2086 if (isProgressIndicator() || isSlider() || isScrollbar()) 2087 2087 return true; 2088 2088 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r228827 r229112 34 34 #include "AccessibilityScrollView.h" 35 35 #include "AccessibilityTable.h" 36 #include "AccessibleSetValueEvent.h" 36 37 #include "DOMTokenList.h" 37 38 #include "Editing.h" … … 998 999 if (auto* pressObject = cache->getOrCreate(pressElement)) { 999 1000 auto event = Event::create(eventNames().accessibleclickEvent, true, true); 1000 pressObject->dispatchAccessibilityEvent(event); 1001 if (event->defaultPrevented()) 1001 if (pressObject->dispatchAccessibilityEvent(event)) 1002 1002 return true; 1003 1003 } … … 2154 2154 } 2155 2155 2156 voidAccessibilityObject::dispatchAccessibilityEvent(Event& event)2156 bool AccessibilityObject::dispatchAccessibilityEvent(Event& event) 2157 2157 { 2158 2158 Vector<Element*> eventPath; … … 2163 2163 2164 2164 EventDispatcher::dispatchEvent(eventPath, event); 2165 2166 // return true if preventDefault() was called, so that we don't execute the fallback behavior. 2167 return event.defaultPrevented(); 2168 } 2169 2170 bool AccessibilityObject::dispatchAccessibleSetValueEvent(const String& value) 2171 { 2172 if (!canSetValueAttribute()) 2173 return false; 2174 auto event = AccessibleSetValueEvent::create(eventNames().accessiblesetvalueEvent, value); 2175 return dispatchAccessibilityEvent(event); 2165 2176 } 2166 2177 -
trunk/Source/WebCore/accessibility/AccessibilityObject.h
r228827 r229112 896 896 bool hasTagName(const QualifiedName&) const; 897 897 898 void dispatchAccessibilityEvent(Event&); 898 bool dispatchAccessibilityEvent(Event&); 899 bool dispatchAccessibleSetValueEvent(const String&); 899 900 900 901 virtual VisiblePositionRange visiblePositionRange() const { return VisiblePositionRange(); } -
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
r228427 r229112 1758 1758 if (!m_renderer || !is<Element>(m_renderer->node())) 1759 1759 return; 1760 if (dispatchAccessibleSetValueEvent(string)) 1761 return; 1762 1760 1763 Element& element = downcast<Element>(*m_renderer->node()); 1761 1764 RenderObject& renderer = *m_renderer; -
trunk/Source/WebCore/accessibility/AccessibilityScrollbar.cpp
r224074 r229112 99 99 100 100 float newValue = value * m_scrollbar->maximum(); 101 if (dispatchAccessibleSetValueEvent(String::number(newValue))) 102 return; 101 103 m_scrollbar->scrollableArea().scrollToOffsetWithoutAnimation(m_scrollbar->orientation(), newValue); 102 104 } -
trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp
r224074 r229112 129 129 void AccessibilitySlider::setValue(const String& value) 130 130 { 131 if (dispatchAccessibleSetValueEvent(value)) 132 return; 133 131 134 HTMLInputElement* input = inputElement(); 132 135 -
trunk/Source/WebCore/dom/Element.idl
r228827 r229112 144 144 // Accessibility events. 145 145 [EnabledAtRuntime=AccessibilityObjectModel] attribute EventHandler onaccessibleclick; 146 [EnabledAtRuntime=AccessibilityObjectModel] attribute EventHandler onaccessiblesetvalue; 146 147 }; 147 148 -
trunk/Source/WebCore/dom/EventNames.h
r228827 r229112 47 47 macro(abort) \ 48 48 macro(accessibleclick) \ 49 macro(accessiblesetvalue) \ 49 50 macro(activate) \ 50 51 macro(active) \ -
trunk/Source/WebCore/dom/EventNames.in
r226766 r229112 77 77 MediaKeyMessageEvent conditional=ENCRYPTED_MEDIA 78 78 VRDisplayEvent 79 AccessibleSetValueEvent
Note: See TracChangeset
for help on using the changeset viewer.