Changeset 229178 in webkit

Timestamp:

Mar 2, 2018 9:48:06 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

WebProcessProxy should handle its completion handler at destruction time
​https://bugs.webkit.org/show_bug.cgi?id=183224

Patch by Youenn Fablet <​youenn@apple.com> on 2018-03-02
Reviewed by Brady Eidson.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):

• UIProcess/WebProcessProxy.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebProcessProxy.cpp (modified) (1 diff)
• UIProcess/WebProcessProxy.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-03-02  Youenn Fablet  <youenn@apple.com>
+
+        WebProcessProxy should handle its completion handler at destruction time
+        https://bugs.webkit.org/show_bug.cgi?id=183224
+
+        Reviewed by Brady Eidson.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::~WebProcessProxy):
+        * UIProcess/WebProcessProxy.h:
+
 2018-03-02  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp

@@ -147 +147 @@
     while (m_numberOfTimesSuddenTerminationWasDisabled-- > 0)
         WebCore::enableSuddenTermination();
+
+    for (auto& callback : m_localPortActivityCompletionHandlers.values())
+        callback(MessagePortChannelProvider::HasActivity::No);
 }
 

trunk/Source/WebKit/UIProcess/WebProcessProxy.h

@@ -328 +328 @@
 
     HashSet<WebCore::MessagePortIdentifier> m_processEntangledPorts;
-    HashMap<uint64_t, CompletionHandler<void()>> m_messageBatchDeliveryCompletionHandlers;
+    HashMap<uint64_t, Function<void()>> m_messageBatchDeliveryCompletionHandlers;
     HashMap<uint64_t, CompletionHandler<void(WebCore::MessagePortChannelProvider::HasActivity)>> m_localPortActivityCompletionHandlers;
 };