Changeset 229499 in webkit


Ignore:
Timestamp:
Mar 9, 2018 7:37:13 PM (6 years ago)
Author:
n_wang@apple.com
Message:

AX: AOM: More accessibility events support
https://bugs.webkit.org/show_bug.cgi?id=183023
<rdar://problem/37764380>

Reviewed by Chris Fleizach.

Source/WebCore:

The test is crashing when we call updateBackingStore when
the AXObjectCache object is gone. Added a check to fix that.

Modified the test by using the right format of setTimeout and extended the delay.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

LayoutTests:

  • accessibility/mac/AOM-events-webarea-crash.html:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r229496 r229499  
     12018-03-09  Nan Wang  <n_wang@apple.com>
     2
     3        AX: AOM: More accessibility events support
     4        https://bugs.webkit.org/show_bug.cgi?id=183023
     5        <rdar://problem/37764380>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        * accessibility/mac/AOM-events-webarea-crash.html:
     10
    1112018-03-09  Ryan Haddad  <ryanhaddad@apple.com>
    212
  • trunk/LayoutTests/accessibility/mac/AOM-events-webarea-crash.html

    r229452 r229499  
    2020
    2121        // make sure we don't crash after focusing onto the web area.
    22         setTimeout(finishJSTest(), 50);
     22        setTimeout(function() {
     23            finishJSTest();
     24        }, 100);
    2325    }
    2426
  • trunk/Source/WebCore/ChangeLog

    r229498 r229499  
     12018-03-09  Nan Wang  <n_wang@apple.com>
     2
     3        AX: AOM: More accessibility events support
     4        https://bugs.webkit.org/show_bug.cgi?id=183023
     5        <rdar://problem/37764380>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        The test is crashing when we call updateBackingStore when
     10        the AXObjectCache object is gone. Added a check to fix that.
     11
     12        Modified the test by using the right format of setTimeout and extended the delay.
     13
     14        * accessibility/AccessibilityObject.cpp:
     15        (WebCore::AccessibilityObject::updateBackingStore):
     16
    1172018-03-09  Ross Kirsling  <ross.kirsling@sony.com>
    218
  • trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

    r229452 r229499  
    17781778void AccessibilityObject::updateBackingStore()
    17791779{
     1780    if (!axObjectCache())
     1781        return;
     1782   
    17801783    // Updating the layout may delete this object.
    17811784    RefPtr<AccessibilityObject> protectedThis(this);
Note: See TracChangeset for help on using the changeset viewer.