Changeset 230076 in webkit

Timestamp:

Mar 29, 2018 9:28:03 AM (6 years ago)

Author:

Brent Fulgham

Message:

REGRESSION(r229480): ERROR: Unhandled web process message 'WebCookieManager:SetHTTPCookieAcceptPolicy'
​https://bugs.webkit.org/show_bug.cgi?id=184124
<rdar://problem/38998971>

Reviewed by Chris Dumez.

Cookie accept policy messages were still being sent to the WebContent process after
I removed cookie access in r229480. The WebContent process no longer recognizes these
messages, and generates logging to that effect.

This patch stops sending these unnecessary messages to the WebContent process. Only the
Network process needs to receive this information.

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebCookieManagerProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-03-29  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION(r229480): ERROR: Unhandled web process message 'WebCookieManager:SetHTTPCookieAcceptPolicy'
+        https://bugs.webkit.org/show_bug.cgi?id=184124
+        <rdar://problem/38998971>
+
+        Reviewed by Chris Dumez.
+
+        Cookie accept policy messages were still being sent to the WebContent process after
+        I removed cookie access in r229480. The WebContent process no longer recognizes these
+        messages, and generates logging to that effect.
+        
+        This patch stops sending these unnecessary messages to the WebContent process. Only the
+        Network process needs to receive this information.
+
+        * UIProcess/WebCookieManagerProxy.cpp:
+        (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
+
 2018-03-29  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
 

trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp

@@ -253 +253 @@
 #endif
 
-    // The policy is not sent to newly created processes (only Soup does that via setInitialHTTPCookieAcceptPolicy()). This is not a serious problem, because:
-    // - When testing, we only have one WebProcess and one NetworkProcess, and WebKitTestRunner never restarts them;
-    // - When not testing, Cocoa has the policy persisted, and thus new processes use it (even for ephemeral sessions).
-    processPool()->sendToAllProcesses(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID()));
-
     auto callbackID = m_callbacks.put(WTFMove(callbackFunction));
     processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID(callbackID)));