Changeset 230286 in webkit

Timestamp:

Apr 4, 2018 5:22:09 PM (6 years ago)

Author:

BJ Burg

Message:

[Cocoa] WebDriver: test imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_non_session_cookie fails
​https://bugs.webkit.org/show_bug.cgi?id=184314
<rdar://problem/39186578>

Reviewed by Timothy Hatcher.

Covered by several tests in add_cookie.py per the bug title.

• platform/network/cocoa/CookieCocoa.mm:

(WebCore::Cookie::operator NSHTTPCookie * const):
By converting an integral UNIX timestamp to |maxAge| fractional seconds into the future, we introduce unwanted
precision that is truncated when switching back to a UNIX timestamp later. Always round up maxAge so that
the truncated value and actual value are the same.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cocoa/CookieCocoa.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-04  Brian Burg  <bburg@apple.com>
+
+        [Cocoa] WebDriver: test imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_non_session_cookie fails
+        https://bugs.webkit.org/show_bug.cgi?id=184314
+        <rdar://problem/39186578>
+
+        Reviewed by Timothy Hatcher.
+
+        Covered by several tests in add_cookie.py per the bug title.
+
+        * platform/network/cocoa/CookieCocoa.mm:
+        (WebCore::Cookie::operator NSHTTPCookie * const):
+        By converting an integral UNIX timestamp to |maxAge| fractional seconds into the future, we introduce unwanted
+        precision that is truncated when switching back to a UNIX timestamp later. Always round up maxAge so that
+        the truncated value and actual value are the same.
+
 2018-04-04  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm

@@ -106 +106 @@
 
     NSDate *expirationDate = [NSDate dateWithTimeIntervalSince1970:expires / 1000.0];
-    auto maxAge = [expirationDate timeIntervalSinceNow];
+    auto maxAge = ceil([expirationDate timeIntervalSinceNow]);
     if (maxAge > 0)
         [properties setObject:[NSString stringWithFormat:@"%f", maxAge] forKey:NSHTTPCookieMaximumAge];