Changeset 230349 in webkit
- Timestamp:
- Apr 6, 2018 12:31:15 PM (6 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r230346 r230349 1 2018-04-06 Zalan Bujtas <zalan@apple.com> 2 3 Flex child does not get repainted when it is inserted back to the render tree. 4 https://bugs.webkit.org/show_bug.cgi?id=184361 5 <rdar://problem/34528716> 6 7 Reviewed by Antti Koivisto. 8 9 * fast/flexbox/missing-repaint-when-flext-item-never-had-layout-expected.txt: Added. 10 * fast/flexbox/missing-repaint-when-flext-item-never-had-layout.html: Added. 11 1 12 2018-04-06 Daniel Bates <dabates@apple.com> 2 13 -
trunk/Source/WebCore/ChangeLog
r230348 r230349 1 2018-04-06 Zalan Bujtas <zalan@apple.com> 2 3 Flex child does not get repainted when it is inserted back to the render tree. 4 https://bugs.webkit.org/show_bug.cgi?id=184361 5 <rdar://problem/34528716> 6 7 Reviewed by Antti Koivisto. 8 9 As with any regular block children, we should issue full repaint for flexbox items on their 10 first layout (see RenderBlockFlow::layoutBlockChild()). 11 12 Test: fast/flexbox/missing-repaint-when-flext-item-never-had-layout.html 13 14 * rendering/RenderFlexibleBox.cpp: 15 (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): 16 1 17 2018-04-06 Ms2ger <Ms2ger@igalia.com> 2 18 -
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
r229531 r230349 1553 1553 const auto& flexItem = children[i]; 1554 1554 auto& child = flexItem.box; 1555 bool childHadLayout = child.everHadLayout(); 1555 1556 1556 1557 ASSERT(!flexItem.box.isOutOfFlowPositioned()); … … 1583 1584 m_relaidOutChildren.add(&child); 1584 1585 child.layoutIfNeeded(); 1586 if (!childHadLayout && child.checkForRepaintDuringLayout()) { 1587 child.repaint(); 1588 child.repaintOverhangingFloats(true); 1589 } 1585 1590 1586 1591 updateAutoMarginsInMainAxis(child, autoMarginOffset);
Note: See TracChangeset
for help on using the changeset viewer.