Changeset 230359 in webkit
- Timestamp:
- Apr 6, 2018 4:53:30 PM (6 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r230326 r230359 1 2018-04-05 Ryosuke Niwa <rniwa@webkit.org> 2 3 Make all sync IPCs during ScriptDisallowedScope set DoNotProcessIncomingMessagesWhenWaitingForSyncReply 4 https://bugs.webkit.org/show_bug.cgi?id=182449 5 <rdar://problem/39222541> 6 7 Reviewed by Chris Dumez. 8 9 Release assert that a sync IPC inside ScriptDisallowedScope sets DoNotProcessIncomingMessagesWhenWaitingForSyncReply 10 to avoid executing arbitrary scripts as a result of processing incoming sync IPCs. 11 12 * Platform/IPC/Connection.h: 13 (IPC::Connection::sendSync): Added the release assertion. 14 1 15 2018-04-05 Youenn Fablet <youenn@apple.com> 2 16 -
trunk/Source/WebKit/Platform/IPC/Connection.h
r230314 r230359 33 33 #include "HandleMessage.h" 34 34 #include "MessageReceiver.h" 35 #include <WebCore/ScriptDisallowedScope.h> 35 36 #include <atomic> 36 37 #include <wtf/Condition.h> … … 388 389 COMPILE_ASSERT(T::isSync, SyncMessageExpected); 389 390 391 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(sendSyncOptions.contains(SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply) 392 || WebCore::ScriptDisallowedScope::isEventAllowedInMainThread()); 393 390 394 uint64_t syncRequestID = 0; 391 395 std::unique_ptr<Encoder> encoder = createSyncMessageEncoder(T::receiverName(), T::name(), destinationID, syncRequestID);
Note: See TracChangeset
for help on using the changeset viewer.