Changeset 230377 in webkit

Timestamp:

Apr 8, 2018 9:47:21 AM (6 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Fix incorrect assertion for VM's regexp buffer lock
​https://bugs.webkit.org/show_bug.cgi?id=184398

Reviewed by Mark Lam.

isLocked check before taking a lock is incorrect.

• runtime/VM.cpp:

(JSC::VM::acquireRegExpPatternContexBuffer):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/VM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-04-08  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] Fix incorrect assertion for VM's regexp buffer lock
+        https://bugs.webkit.org/show_bug.cgi?id=184398
+
+        Reviewed by Mark Lam.
+
+        isLocked check before taking a lock is incorrect.
+
+        * runtime/VM.cpp:
+        (JSC::VM::acquireRegExpPatternContexBuffer):
+
 2018-04-08  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -902 +902 @@
 char* VM::acquireRegExpPatternContexBuffer()
 {
-    ASSERT(!m_regExpPatternContextLock.isLocked());
-
     m_regExpPatternContextLock.lock();
+    ASSERT(m_regExpPatternContextLock.isLocked());
     if (!m_regExpPatternContexBuffer)
         m_regExpPatternContexBuffer = makeUniqueArray<char>(VM::patternContextBufferSize);