Changeset 230474 in webkit

Timestamp:

Apr 10, 2018 12:58:19 AM (6 years ago)

Author:

Yusuke Suzuki

Message:

[bmalloc] Name Scavenger thread "bmalloc scavenger"
​https://bugs.webkit.org/show_bug.cgi?id=166684

Reviewed by Saam Barati.

We name the thread for bmalloc Scavenger "bmalloc scavenger".
It is useful for debugging. In Linux environment, it will be
shown in GDB.

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::threadRunLoop):
(bmalloc::Scavenger::setName):

• bmalloc/Scavenger.h:

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Scavenger.cpp (modified) (2 diffs)
• bmalloc/Scavenger.h (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2018-04-09  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [bmalloc] Name Scavenger thread "bmalloc scavenger"
+        https://bugs.webkit.org/show_bug.cgi?id=166684
+
+        Reviewed by Saam Barati.
+
+        We name the thread for bmalloc Scavenger "bmalloc scavenger".
+        It is useful for debugging. In Linux environment, it will be
+        shown in GDB.
+
+        * bmalloc/Scavenger.cpp:
+        (bmalloc::Scavenger::threadRunLoop):
+        (bmalloc::Scavenger::setName):
+        * bmalloc/Scavenger.h:
+
 2018-04-09  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/bmalloc/bmalloc/Scavenger.cpp

@@ -227 +227 @@
 {
     setSelfQOSClass();
+    setThreadName("bmalloc scavenger");
     
     // This loop ratchets downward from most active to least active state. While
@@ -271 +272 @@
 }
 
+void Scavenger::setThreadName(const char* name)
+{
+    BUNUSED(name);
+#if BOS(DARWIN)
+    pthread_setname_np(name);
+#elif BOS(LINUX)
+    // Truncate the given name since Linux limits the size of the thread name 16 including null terminator.
+    std::array<char, 16> buf;
+    strncpy(buf.data(), name, buf.size() - 1);
+    buf[buf.size() - 1] = '\0';
+    pthread_setname_np(pthread_self(), buf.data());
+#endif
+}
+
 void Scavenger::setSelfQOSClass()
 {

trunk/Source/bmalloc/bmalloc/Scavenger.h

@@ -84 +84 @@
     
     void setSelfQOSClass();
+    void setThreadName(const char*);
 
     std::atomic<State> m_state { State::Sleep };