Changeset 230553 in webkit

Timestamp:

Apr 11, 2018, 7:44:06 PM (9 years ago)

Author:

sbarati@apple.com

Message:

raise partial scavenge interval on x86-64
​https://bugs.webkit.org/show_bug.cgi?id=184521

Rubber-stamped by Filip Pizlo.

This patch is an attempt to recover the 1-3% JetStream regression
my initial partial scavenging patch introduced on some Macs.

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::threadRunLoop):

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Scavenger.cpp (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2018-04-11  Saam Barati  <sbarati@apple.com>
+
+        raise partial scavenge interval on x86-64
+        https://bugs.webkit.org/show_bug.cgi?id=184521
+
+        Rubber-stamped by Filip Pizlo.
+
+        This patch is an attempt to recover the 1-3% JetStream regression
+        my initial partial scavenging patch introduced on some Macs.
+
+        * bmalloc/Scavenger.cpp:
+        (bmalloc::Scavenger::threadRunLoop):
+
 2018-04-10  Saam Barati  <sbarati@apple.com>
 

trunk/Source/bmalloc/bmalloc/Scavenger.cpp

@@ -408 +408 @@
             }
 
-            if (timeSinceLastScavenge < std::chrono::milliseconds(8000)) {
+#if BCPU(X86_64)
+            auto partialScavengeInterval = std::chrono::milliseconds(20000);
+#else
+            auto partialScavengeInterval = std::chrono::milliseconds(8000);
+#endif
+            if (timeSinceLastScavenge < partialScavengeInterval) {
                 // Rate limit partial scavenges.
                 return ScavengeMode::None;