Changeset 230554 in webkit

Timestamp:

Apr 11, 2018 8:55:51 PM (6 years ago)

Author:

Chris Dumez

Message:

input.webkitEntries does not work as expected when folder contains accented chars
​https://bugs.webkit.org/show_bug.cgi?id=184517
<rdar://problem/39265537>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use String::fromUTF8() to construct a WTF String from the char* returned by
dirname() in FileSystem::directoryName(). Previously, we were just calling
the String constructor, which would treat the input as latin 1 instead of
UTF-8.

Test: fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html

• platform/posix/FileSystemPOSIX.cpp:

(WebCore::FileSystem::directoryName):

LayoutTests:

Add layout test coverage.

• fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt: Added.
• fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/file/entries-api/resources/älo (added)
• LayoutTests/fast/forms/file/entries-api/resources/älo/test.txt (added)
• LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt (added)
• LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/posix/FileSystemPOSIX.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-04-11  Chris Dumez  <cdumez@apple.com>
+
+        input.webkitEntries does not work as expected when folder contains accented chars
+        https://bugs.webkit.org/show_bug.cgi?id=184517
+        <rdar://problem/39265537>
+
+        Reviewed by Ryosuke Niwa.
+
+        Add layout test coverage.
+
+        * fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt: Added.
+        * fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html: Added.
+
 2018-04-11  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-11  Chris Dumez  <cdumez@apple.com>
+
+        input.webkitEntries does not work as expected when folder contains accented chars
+        https://bugs.webkit.org/show_bug.cgi?id=184517
+        <rdar://problem/39265537>
+
+        Reviewed by Ryosuke Niwa.
+
+        Use String::fromUTF8() to construct a WTF String from the char* returned by
+        dirname() in FileSystem::directoryName(). Previously, we were just calling
+        the String constructor, which would treat the input as latin 1 instead of
+        UTF-8.
+
+        Test: fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html
+
+        * platform/posix/FileSystemPOSIX.cpp:
+        (WebCore::FileSystem::directoryName):
+
 2018-04-11  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp

@@ -352 +352 @@
         return String();
 
-    return dirname(fsRep.mutableData());
+    return String::fromUTF8(dirname(fsRep.mutableData()));
 }