Changeset 230577 in webkit

Timestamp:

Apr 12, 2018, 9:11:22 AM (9 years ago)

Author:

Yusuke Suzuki

Message:

[DFG] Remove compileBigIntEquality in DFG 32bit
​https://bugs.webkit.org/show_bug.cgi?id=184535

Reviewed by Saam Barati.

We can have the unified implementation for compileBigIntEquality.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileBigIntEquality):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileBigIntEquality): Deleted.

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileBigIntEquality): Deleted.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.cpp (modified) (1 diff)
• dfg/DFGSpeculativeJIT32_64.cpp (modified) (1 diff)
• dfg/DFGSpeculativeJIT64.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [DFG] Remove compileBigIntEquality in DFG 32bit
+        https://bugs.webkit.org/show_bug.cgi?id=184535
+
+        Reviewed by Saam Barati.
+
+        We can have the unified implementation for compileBigIntEquality.
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::compileBigIntEquality):
+        * dfg/DFGSpeculativeJIT32_64.cpp:
+        (JSC::DFG::SpeculativeJIT::compileBigIntEquality): Deleted.
+        * dfg/DFGSpeculativeJIT64.cpp:
+        (JSC::DFG::SpeculativeJIT::compileBigIntEquality): Deleted.
+
 2018-04-12  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

@@ -12941 +12941 @@
 }
 
+void SpeculativeJIT::compileBigIntEquality(Node* node)
+{
+    // FIXME: [ESNext][BigInt] Create specialized version of strict equals for BigIntUse
+    // https://bugs.webkit.org/show_bug.cgi?id=182895
+    SpeculateCellOperand left(this, node->child1());
+    SpeculateCellOperand right(this, node->child2());
+    GPRTemporary result(this, Reuse, left);
+    GPRReg leftGPR = left.gpr();
+    GPRReg rightGPR = right.gpr();
+    GPRReg resultGPR = result.gpr();
+
+    left.use();
+    right.use();
+
+    speculateBigInt(node->child1(), leftGPR);
+    speculateBigInt(node->child2(), rightGPR);
+
+    JITCompiler::Jump notEqualCase = m_jit.branchPtr(JITCompiler::NotEqual, leftGPR, rightGPR);
+
+    m_jit.move(JITCompiler::TrustedImm32(1), resultGPR);
+
+    JITCompiler::Jump done = m_jit.jump();
+
+    notEqualCase.link(&m_jit);
+
+    silentSpillAllRegisters(resultGPR);
+    callOperation(operationCompareStrictEqCell, resultGPR, leftGPR, rightGPR);
+    silentFillAllRegisters();
+
+    done.link(&m_jit);
+
+    unblessedBooleanResult(resultGPR, node, UseChildrenCalledExplicitly);
+}
+
 } } // namespace JSC::DFG
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

@@ -4268 +4268 @@
 }
 
-void SpeculativeJIT::compileBigIntEquality(Node* node)
-{
-    // FIXME: [ESNext][BigInt] Create specialized version of strict equals for BigIntUse
-    // https://bugs.webkit.org/show_bug.cgi?id=182895
-    SpeculateCellOperand left(this, node->child1());
-    SpeculateCellOperand right(this, node->child2());
-    GPRReg leftPayloadGPR = left.gpr();
-    GPRReg rightPayloadGPR = right.gpr();
-
-    GPRTemporary resultPayload(this, Reuse, left);
-    GPRReg resultPayloadGPR = resultPayload.gpr();
-
-    left.use();
-    right.use();
-
-    speculateBigInt(node->child1(), leftPayloadGPR);
-    speculateBigInt(node->child2(), rightPayloadGPR);
-
-    JITCompiler::Jump notEqualCase = m_jit.branchPtr(JITCompiler::NotEqual, leftPayloadGPR, rightPayloadGPR);
-
-    m_jit.move(JITCompiler::TrustedImm32(true), resultPayloadGPR);
-    JITCompiler::Jump done = m_jit.jump();
-
-    notEqualCase.link(&m_jit);
-
-    silentSpillAllRegisters(resultPayloadGPR);
-    callOperation(operationCompareStrictEqCell, resultPayloadGPR, leftPayloadGPR, rightPayloadGPR);
-    silentFillAllRegisters();
-
-    m_jit.andPtr(JITCompiler::TrustedImm32(1), resultPayloadGPR);
-
-    done.link(&m_jit);
-
-    booleanResult(resultPayloadGPR, node, UseChildrenCalledExplicitly);
-}
-
 #endif
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp

@@ -4908 +4908 @@
 }
 
-void SpeculativeJIT::compileBigIntEquality(Node* node)
-{
-    // FIXME: [ESNext][BigInt] Create specialized version of strict equals for BigIntUse
-    // https://bugs.webkit.org/show_bug.cgi?id=182895
-    SpeculateCellOperand left(this, node->child1());
-    SpeculateCellOperand right(this, node->child2());
-    GPRTemporary result(this);
-    GPRReg leftGPR = left.gpr();
-    GPRReg rightGPR = right.gpr();
-    GPRReg resultGPR = result.gpr();
-
-    left.use();
-    right.use();
-
-    speculateBigInt(node->child1(), leftGPR);
-    speculateBigInt(node->child2(), rightGPR);
-
-    JITCompiler::Jump notEqualCase = m_jit.branch64(JITCompiler::NotEqual, leftGPR, rightGPR);
-
-    m_jit.move(JITCompiler::TrustedImm64(JSValue::encode(jsBoolean(true))), resultGPR);
-
-    JITCompiler::Jump done = m_jit.jump();
-
-    notEqualCase.link(&m_jit);
-
-    silentSpillAllRegisters(resultGPR);
-    callOperation(operationCompareStrictEqCell, resultGPR, leftGPR, rightGPR);
-    silentFillAllRegisters();
-
-    m_jit.and64(JITCompiler::TrustedImm32(1), resultGPR);
-    m_jit.or32(JITCompiler::TrustedImm32(ValueFalse), resultGPR);
-
-    done.link(&m_jit);
-
-    jsValueResult(resultGPR, m_currentNode, DataFormatJSBoolean, UseChildrenCalledExplicitly);
-}
-
 #endif