Changeset 230623 in webkit

Timestamp:

Apr 12, 2018, 11:52:36 PM (8 years ago)

Author:

sbarati@apple.com

Message:

Lessen partial scavenge interval on x86-64
​https://bugs.webkit.org/show_bug.cgi?id=184577

Rubber-stamped by Filip Pizlo.

I initially made the scavenge interval longer because I had thought the
shorter interval caused a JetStream regression. I was mistaken though.
I was looking at the wrong commit range when analyzing perf data.

This patch shortens the interval, but still keeps x86-64 50% longer than
other architectures. We know that scavenging frequently on Mac is less
important to overall system performance than it is on iOS.

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::threadRunLoop):

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Scavenger.cpp (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2018-04-12  Saam Barati  <sbarati@apple.com>
+
+        Lessen partial scavenge interval on x86-64
+        https://bugs.webkit.org/show_bug.cgi?id=184577
+
+        Rubber-stamped by Filip Pizlo.
+
+        I initially made the scavenge interval longer because I had thought the
+        shorter interval caused a JetStream regression. I was mistaken though.
+        I was looking at the wrong commit range when analyzing perf data.
+        
+        This patch shortens the interval, but still keeps x86-64 50% longer than
+        other architectures. We know that scavenging frequently on Mac is less
+        important to overall system performance than it is on iOS.
+
+        * bmalloc/Scavenger.cpp:
+        (bmalloc::Scavenger::threadRunLoop):
+
 2018-04-12  Saam Barati  <sbarati@apple.com>
 

trunk/Source/bmalloc/bmalloc/Scavenger.cpp

@@ -409 +409 @@
 
 #if BCPU(X86_64)
-            auto partialScavengeInterval = std::chrono::milliseconds(36000);
+            auto partialScavengeInterval = std::chrono::milliseconds(12000);
 #else
             auto partialScavengeInterval = std::chrono::milliseconds(8000);