Changeset 230625 in webkit

Timestamp:

Apr 13, 2018, 1:50:42 AM (8 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer] Convert GStreamerUtilities in GStreamerCommon and include the GStreamer smart pointer traits
​https://bugs.webkit.org/show_bug.cgi?id=184533

Reviewed by Philippe Normand.

Renamed GStreamerUtilities* files into GStreamerCommon* and
modified files including them accordingly. Include
GRefPtrGStreamer.h and GUniquePtrGStreamer.h in GStreamerCommon.h
to avoid problems destroying objects when those files are
forgotten to be included.

Source/WebCore:

• Modules/webaudio/AudioContext.cpp:
• platform/GStreamer.cmake:
• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
• platform/graphics/gstreamer/GStreamerCommon.cpp: Renamed from Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp.
• platform/graphics/gstreamer/GStreamerCommon.h: Renamed from Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h.
• platform/graphics/gstreamer/ImageGStreamer.h:
• platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
• platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
• platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
• platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
• platform/graphics/gstreamer/MediaSampleGStreamer.h:
• platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:
• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
• platform/graphics/gstreamer/mse/AppendPipeline.cpp:
• platform/graphics/gstreamer/mse/AppendPipeline.h:
• platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:
• platform/graphics/gstreamer/mse/GStreamerMediaDescription.h:
• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
• platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h:

Source/WebKit:

• UIProcess/gtk/WebProcessPoolGtk.cpp:
• UIProcess/wpe/WebProcessPoolWPE.cpp:
• WebProcess/soup/WebProcessSoup.cpp:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/Modules/webaudio/AudioContext.cpp (modified) (1 diff)
• WebCore/platform/GStreamer.cmake (modified) (1 diff)
• WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp (moved) (moved from trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp ) (1 diff)
• WebCore/platform/graphics/gstreamer/GStreamerCommon.h (moved) (moved from trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h ) (1 diff)
• WebCore/platform/graphics/gstreamer/ImageGStreamer.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp (modified) (1 diff)
• WebKit/UIProcess/wpe/WebProcessPoolWPE.cpp (modified) (1 diff)
• WebKit/WebProcess/soup/WebProcessSoup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer] Convert GStreamerUtilities in GStreamerCommon and include the GStreamer smart pointer traits
+        https://bugs.webkit.org/show_bug.cgi?id=184533
+
+        Reviewed by Philippe Normand.
+
+        Renamed GStreamerUtilities* files into GStreamerCommon* and
+        modified files including them accordingly. Include
+        GRefPtrGStreamer.h and GUniquePtrGStreamer.h in GStreamerCommon.h
+        to avoid problems destroying objects when those files are
+        forgotten to be included.
+
+        * Modules/webaudio/AudioContext.cpp:
+        * platform/GStreamer.cmake:
+        * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+        * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
+        * platform/graphics/gstreamer/GStreamerCommon.cpp: Renamed from Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp.
+        * platform/graphics/gstreamer/GStreamerCommon.h: Renamed from Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h.
+        * platform/graphics/gstreamer/ImageGStreamer.h:
+        * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
+        * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
+        * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+        * platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
+        * platform/graphics/gstreamer/MediaSampleGStreamer.h:
+        * platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
+        * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
+        * platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
+        * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
+        * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        * platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:
+        * platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
+        * platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
+        * platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
+        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+        * platform/graphics/gstreamer/mse/AppendPipeline.h:
+        * platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:
+        * platform/graphics/gstreamer/mse/GStreamerMediaDescription.h:
+        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
+        * platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
+        * platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
+        * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h:
+
 2018-04-12  Christopher Reid  <chris.reid@sony.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp

@@ -86 +86 @@
 
 #if USE(GSTREAMER)
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #endif
 

trunk/Source/WebCore/platform/GStreamer.cmake

@@ -9 +9 @@
         platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp
         platform/graphics/gstreamer/GRefPtrGStreamer.cpp
-        platform/graphics/gstreamer/GStreamerUtilities.cpp
+        platform/graphics/gstreamer/GStreamerCommon.cpp
         platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp
         platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp

trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp

@@ -26 +26 @@
 #include "AudioBus.h"
 #include "AudioIOCallback.h"
-#include "GRefPtrGStreamer.h"
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include <gst/app/gstappsrc.h>
 #include <gst/audio/audio-info.h>

trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h

@@ -29 +29 @@
 
 #include "AudioTrackPrivate.h"
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "TrackPrivateBaseGStreamer.h"
 #include <gst/gst.h>

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

@@ -20 +20 @@
 
 #include "config.h"
+#include "GStreamerCommon.h"
 
 #if USE(GSTREAMER)
-#include "GStreamerUtilities.h"
-
-#include "GRefPtrGStreamer.h"
+
 #include "GstAllocatorFastMalloc.h"
 #include "IntSize.h"

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h

@@ -20 +20 @@
 #pragma once
 
-
 #if USE(GSTREAMER)
 #include "FloatSize.h"
+#include "GRefPtrGStreamer.h"
+#include "GUniquePtrGStreamer.h"
 #include <gst/gst.h>
 #include <gst/video/video-format.h>

trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h

@@ -25 +25 @@
 #include "BitmapImage.h"
 #include "FloatRect.h"
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 
 #include <gst/gst.h>

trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp

@@ -23 +23 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER)
 
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 
 #include <cairo.h>

trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp

@@ -30 +30 @@
 #include "InbandTextTrackPrivateGStreamer.h"
 
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "Logging.h"
 #include <glib-object.h>

trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h

@@ -28 +28 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(VIDEO_TRACK)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "InbandTextTrackPrivate.h"
 #include "TrackPrivateBaseGStreamer.h"

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -30 +30 @@
 
 #include "FileSystem.h"
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "HTTPHeaderNames.h"
 #include "MIMETypeRegistry.h"

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

@@ -27 +27 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaPlayerPrivateGStreamerBase.h"
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

@@ -28 +28 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER)
 
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "GraphicsContext.h"
 #include "ImageGStreamer.h"

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h

@@ -26 +26 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MainThreadNotifier.h"
 #include "MediaPlayerPrivate.h"

trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp

@@ -22 +22 @@
 #include "MediaSampleGStreamer.h"
 
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 
 #if ENABLE(VIDEO) && USE(GSTREAMER)

trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h

@@ -24 +24 @@
 
 #include "FloatSize.h"
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaSample.h"
 #include <wtf/text/AtomicString.h>

trunk/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp

@@ -29 +29 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(VIDEO_TRACK)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 
 static GstStaticPadTemplate sinkTemplate =

trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp

@@ -30 +30 @@
 #include "TrackPrivateBaseGStreamer.h"
 
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "Logging.h"
 #include "TrackPrivateBase.h"

trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h

@@ -28 +28 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(VIDEO_TRACK)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MainThreadNotifier.h"
 #include <gst/gst.h>

trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp

@@ -31 +31 @@
 
 #if ENABLE(VIDEO) && USE(GSTREAMER)
-#include "GRefPtrGStreamer.h"
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "IntSize.h"
 #include <glib.h>

trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h

@@ -28 +28 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(VIDEO_TRACK)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "TrackPrivateBaseGStreamer.h"
 #include "VideoTrackPrivate.h"

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -23 +23 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER)
 
-#include "GRefPtrGStreamer.h"
-#include "GStreamerUtilities.h"
-#include "GUniquePtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "HTTPHeaderNames.h"
 #include "MainThreadNotifier.h"

trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp

@@ -22 +22 @@
 #include "config.h"
 #include "GStreamerEMEUtilities.h"
-
-#include "GRefPtrGStreamer.h"
 
 #if ENABLE(ENCRYPTED_MEDIA) && USE(GSTREAMER)

trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h

@@ -24 +24 @@
 #if ENABLE(ENCRYPTED_MEDIA) && USE(GSTREAMER)
 
+#include "GStreamerCommon.h"
 #include <gst/gst.h>
 #include <wtf/text/WTFString.h>

trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp

@@ -25 +25 @@
 #if ENABLE(ENCRYPTED_MEDIA) && USE(GSTREAMER)
 
-#include "GRefPtrGStreamer.h"
 #include "GStreamerEMEUtilities.h"
 #include <gcrypt.h>

trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp

@@ -26 +26 @@
 #if ENABLE(ENCRYPTED_MEDIA) && USE(GSTREAMER)
 
-#include "GRefPtrGStreamer.h"
-#include "GUniquePtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include <wtf/Condition.h>
 #include <wtf/RunLoop.h>

trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

@@ -25 +25 @@
 
 #include "AudioTrackPrivateGStreamer.h"
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "GStreamerEMEUtilities.h"
 #include "GStreamerMediaDescription.h"
-#include "GStreamerUtilities.h"
 #include "MediaSampleGStreamer.h"
 #include "InbandTextTrackPrivateGStreamer.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h

@@ -23 +23 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(MEDIA_SOURCE)
 
-#include "GRefPtrGStreamer.h"
-#include "GUniquePtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaPlayerPrivateGStreamerMSE.h"
 #include "MediaSourceClientGStreamerMSE.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp

@@ -21 +21 @@
 #include "config.h"
 #include "GStreamerMediaDescription.h"
-#include "GStreamerUtilities.h"
-#include "GUniquePtrGStreamer.h"
+#include "GStreamerCommon.h"
 
 #include <gst/pbutils/pbutils.h>

trunk/Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.h

@@ -23 +23 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(MEDIA_SOURCE)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaDescription.h"
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

@@ -31 +31 @@
 #include "AppendPipeline.h"
 #include "AudioTrackPrivateGStreamer.h"
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "InbandTextTrackPrivateGStreamer.h"
 #include "MIMETypeRegistry.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h

@@ -27 +27 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(MEDIA_SOURCE) 
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaPlayerPrivateGStreamer.h"
 #include "MediaSample.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h

@@ -23 +23 @@
 #if ENABLE(VIDEO) && USE(GSTREAMER) && ENABLE(MEDIA_SOURCE)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaSourcePrivate.h"
 #include "MediaSourcePrivateClient.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp

@@ -26 +26 @@
 
 #include "AudioTrackPrivateGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaSampleGStreamer.h"
-#include "GStreamerUtilities.h"
-#include "GUniquePtrGStreamer.h"
 #include "MediaSample.h"
 #include "SourceBufferPrivateGStreamer.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp

@@ -39 +39 @@
 
 #include "ContentType.h"
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "MediaPlayerPrivateGStreamerMSE.h"
 #include "MediaSample.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

@@ -30 +30 @@
 
 #include "AudioTrackPrivateGStreamer.h"
-#include "GStreamerUtilities.h"
+#include "GStreamerCommon.h"
 #include "MediaDescription.h"
 #include "MediaPlayerPrivateGStreamerMSE.h"

trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h

@@ -26 +26 @@
 #if ENABLE(VIDEO) && ENABLE(MEDIA_SOURCE) && USE(GSTREAMER)
 
-#include "GRefPtrGStreamer.h"
+#include "GStreamerCommon.h"
 #include "MediaPlayer.h"
 #include "MediaSource.h"

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer] Convert GStreamerUtilities in GStreamerCommon and include the GStreamer smart pointer traits
+        https://bugs.webkit.org/show_bug.cgi?id=184533
+
+        Reviewed by Philippe Normand.
+
+        Renamed GStreamerUtilities* files into GStreamerCommon* and
+        modified files including them accordingly. Include
+        GRefPtrGStreamer.h and GUniquePtrGStreamer.h in GStreamerCommon.h
+        to avoid problems destroying objects when those files are
+        forgotten to be included.
+
+        * UIProcess/gtk/WebProcessPoolGtk.cpp:
+        * UIProcess/wpe/WebProcessPoolWPE.cpp:
+        * WebProcess/soup/WebProcessSoup.cpp:
+
 2018-04-12  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp

@@ -36 +36 @@
 #include <JavaScriptCore/RemoteInspectorServer.h>
 #include <WebCore/FileSystem.h>
-#include <WebCore/GStreamerUtilities.h>
+#include <WebCore/GStreamerCommon.h>
 #include <WebCore/NotImplemented.h>
 #include <WebCore/SchemeRegistry.h>

trunk/Source/WebKit/UIProcess/wpe/WebProcessPoolWPE.cpp

@@ -37 +37 @@
 #include <JavaScriptCore/RemoteInspectorServer.h>
 #include <WebCore/FileSystem.h>
-#include <WebCore/GStreamerUtilities.h>
+#include <WebCore/GStreamerCommon.h>
 #include <WebCore/NotImplemented.h>
 #include <WebCore/SchemeRegistry.h>

trunk/Source/WebKit/WebProcess/soup/WebProcessSoup.cpp

@@ -29 +29 @@
 
 #include "WebProcessCreationParameters.h"
-#include <WebCore/GStreamerUtilities.h>
+#include <WebCore/GStreamerCommon.h>
 #include <WebCore/MemoryCache.h>
 #include <WebCore/NetworkStorageSession.h>