Changeset 230633 in webkit

Timestamp:

Apr 13, 2018 9:17:44 AM (6 years ago)

Author:

Brent Fulgham

Message:

REGRESSION(r230468): Improper assertion firing under STP
<rdar://problem/39411676>

Unreviewed, rolling out an improper assertion.

I added an assertion in Bug 184322 that should not have been added. I did not notice that this
call stack was always used in builds where NSApp is still active. Builds where we stop relying
on AppKit runloops uses a different code path to shut down.

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::stopNSAppRunLoop):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/ChildProcessMac.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-13  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION(r230468): Improper assertion firing under STP
+        <rdar://problem/39411676>
+
+        Unreviewed, rolling out an improper assertion.
+
+        I added an assertion in Bug 184322 that should not have been added. I did not notice that this
+        call stack was always used in builds where NSApp is still active. Builds where we stop relying
+        on AppKit runloops uses a different code path to shut down.
+
+        * Shared/mac/ChildProcessMac.mm:
+        (WebKit::ChildProcess::stopNSAppRunLoop):
+
 2018-04-12  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm

@@ -39 +39 @@
 #import <stdlib.h>
 #import <sysexits.h>
-#import <wtf/ProcessPrivilege.h>
 #import <wtf/Scope.h>
 #import <wtf/spi/darwin/SandboxSPI.h>
@@ -207 +206 @@
 {
     ASSERT([NSApp isRunning]);
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
     [NSApp stop:nil];