Changeset 230644 in webkit

Timestamp:

Apr 13, 2018 3:42:24 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

WebKit crashes when libwebrtc.dylib is missing
​https://bugs.webkit.org/show_bug.cgi?id=184607

Rubber-stamped by Jer Noble.

Don't call LibWebRTC related code when libwebrtc is not available.

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::suspend):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        WebKit crashes when libwebrtc.dylib is missing
+        https://bugs.webkit.org/show_bug.cgi?id=184607
+
+        Rubber-stamped by Jer Noble.
+
+        Don't call LibWebRTC related code when libwebrtc is not available.
+
+        * dom/Document.cpp:
+        (WebCore::Document::prepareForDestruction):
+        (WebCore::Document::suspend):
+
 2018-04-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -2359 +2359 @@
 
 #if USE(LIBWEBRTC)
-    if (auto* page = this->page())
-        page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+    // FIXME: This should be moved to Modules/mediastream.
+    if (LibWebRTCProvider::webRTCAvailable()) {
+        if (auto* page = this->page())
+            page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+    }
 #endif
 
@@ -4892 +4895 @@
 
 #if USE(LIBWEBRTC)
-    if (auto* page = this->page())
-        page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+    // FIXME: This should be moved to Modules/mediastream.
+    if (LibWebRTCProvider::webRTCAvailable()) {
+        if (auto* page = this->page())
+            page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+    }
 #endif