Changeset 230667 in webkit

Timestamp:

Apr 16, 2018 1:47:17 AM (6 years ago)

Author:

graouts@webkit.org

Message:

[Web Animations] Ensure we never return -0 through the API
​https://bugs.webkit.org/show_bug.cgi?id=184644

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Record one progression in the Web Animations WPT tests.

• web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:

Source/WebCore:

We could sometimes return -0 instead of 0, which is surprising and leads to an error in WPT tests.
This would happen when playbackRate < 0.

• animation/WebAnimationUtilities.h:

(WebCore::secondsToWebAnimationsAPITime):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/WebAnimationUtilities.h (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2018-04-16  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Ensure we never return -0 through the API
+        https://bugs.webkit.org/show_bug.cgi?id=184644
+
+        Reviewed by Dean Jackson.
+
+        Record one progression in the Web Animations WPT tests.
+
+        * web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:
+
 2018-04-15  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt

@@ -5 +5 @@
 PASS Updating the finished state when playing in reverse past zero 
 PASS Updating the finished state when seeking a reversed animation past zero 
-FAIL Updating the finished state when seeking a reversed animation exactly to zero assert_equals: Hold time is set so current time should NOT change expected 0 but got -0
+PASS Updating the finished state when seeking a reversed animation exactly to zero 
 PASS Updating the finished state when playing before end 
 PASS Updating the finished state when seeking before end 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-16  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Ensure we never return -0 through the API
+        https://bugs.webkit.org/show_bug.cgi?id=184644
+
+        Reviewed by Dean Jackson.
+
+        We could sometimes return -0 instead of 0, which is surprising and leads to an error in WPT tests.
+        This would happen when playbackRate < 0.
+
+        * animation/WebAnimationUtilities.h:
+        (WebCore::secondsToWebAnimationsAPITime):
+
 2018-04-15  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/animation/WebAnimationUtilities.h

@@ -38 +38 @@
     // agents be able to represent input time values with microsecond precision so that a time value (which nominally
     // represents milliseconds) of 0.001 is distinguishable from 0.0.
-    return std::round(time.microseconds()) / 1000;
+    auto roundedTime = std::round(time.microseconds()) / 1000;
+    if (roundedTime == -0)
+        return 0;
+    return roundedTime;
 }